From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 4A68A1C00;
 Tue,  9 May 2017 15:38:41 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga105.fm.intel.com with ESMTP; 09 May 2017 06:38:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,314,1491289200"; d="scan'208";a="1166701507"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by fmsmga002.fm.intel.com with ESMTP; 09 May 2017 06:38:39 -0700
Received: from irsmsx110.ger.corp.intel.com ([169.254.15.151]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.12]) with mapi id 14.03.0319.002;
 Tue, 9 May 2017 14:38:37 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Korynkevych, RomanX" <romanx.korynkevych@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
CC: "Van Haaren, Harry" <harry.van.haaren@intel.com>, "Tahhan, Maryam"
 <maryam.tahhan@intel.com>, "Korynkevych, RomanX"
 <romanx.korynkevych@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v1 1/1] app/procinfo: resource leak fix.
Thread-Index: AQHSxa6fTWeKG6OJYk2blp08Z00AbKHsAiyg
Date: Tue, 9 May 2017 13:38:37 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F0113963F@irsmsx110.ger.corp.intel.com>
References: <1493995649-3220-1-git-send-email-romanx.korynkevych@intel.com>
In-Reply-To: <1493995649-3220-1-git-send-email-romanx.korynkevych@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTAyYmViNmMtZTVmYi00ZWViLTlmNGYtZTAwZGY5NzhkZTdiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImZsRVNUQklxamxVdTNLTW95dytGS2lWYlA0YzcrSVJyM0hyYjBlbW85SWc9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v1 1/1] app/procinfo: resource leak fix.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 May 2017 13:38:42 -0000

Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roman Korynkevych
> Sent: Friday, May 5, 2017 3:47 PM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Tahhan, Maryam
> <maryam.tahhan@intel.com>; Korynkevych, RomanX
> <romanx.korynkevych@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v1 1/1] app/procinfo: resource leak fix.
>=20
> Coverity issue: 143256
> Fixes: 2deb6b5246d7706448d070335b329d1acb754cee ("app/procinfo: add
> collectd format and host id")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Roman Korynkevych <romanx.korynkevych@intel.com>
> ---
>  app/proc_info/main.c | 21 ++++++++++++++++-----
>  1 file changed, 16 insertions(+), 5 deletions(-)
>=20
> diff --git a/app/proc_info/main.c b/app/proc_info/main.c index
> 17a1c87..3d0b621 100644
> --- a/app/proc_info/main.c
> +++ b/app/proc_info/main.c

1)You need to close the stdout_fd even inside proc_info_preparse_args() bef=
ore return -1;
(or)=20

inside below piece of code in main().
ret =3D proc_info_preparse_args(argc, argv);
        if (ret < 0) {
                printf("Failed to parse arguments\n");
                return -1;
        }

2)Also if  stdout_fd =3D dup(STDOUT_FILENO);  can return negative value, Yo=
u may need to exit then? If so can you fix that code as well.

Thanks,
Reshma