From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <reshma.pattan@intel.com> Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9C13358D1 for <dev@dpdk.org>; Thu, 6 Jul 2017 13:48:20 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 06 Jul 2017 04:48:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,317,1496127600"; d="scan'208";a="107794152" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga002.jf.intel.com with ESMTP; 06 Jul 2017 04:48:18 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.126]) by IRSMSX152.ger.corp.intel.com ([169.254.6.83]) with mapi id 14.03.0319.002; Thu, 6 Jul 2017 12:48:17 +0100 From: "Pattan, Reshma" <reshma.pattan@intel.com> To: Stephen Hemminger <stephen@networkplumber.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>, "Jain, Deepak K" <deepak.k.jain@intel.com>, "Van Haaren, Harry" <harry.van.haaren@intel.com>, "piotrx.t.azarewicz@intel.com" <piotrx.t.azarewicz@intel.com>, "Nicolau, Radu" <radu.nicolau@intel.com> Thread-Topic: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 Thread-Index: AQHS7mD33Tc+uEQhBUGlcKYc3K0v0KI5Oz0AgA1zWpA= Date: Thu, 6 Jul 2017 11:48:17 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A21C674@irsmsx110.ger.corp.intel.com> References: <20170522143202.22424-2-michalx.k.jastrzebski@intel.com> <1498470133-29788-1-git-send-email-radu.nicolau@intel.com> <20170627152612.3fabf6fd@xeon-e3> In-Reply-To: <20170627152612.3fabf6fd@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTM4YmEwMmEtZDNmOS00NmQ1LWEzZTktMjQzOGYwOTAzMmNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjM1ekxpYko4eWlGVmd4UXY0T2pIR1lwSjBtQzRlSEZWRVdVVFdjYjNDa3c9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 06 Jul 2017 11:48:21 -0000 Hi , > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, June 27, 2017 11:26 PM > To: Nicolau, Radu <radu.nicolau@intel.com> > Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Pattan, Reshma > <reshma.pattan@intel.com>; Jastrzebski, MichalX K > <michalx.k.jastrzebski@intel.com>; Jain, Deepak K > <deepak.k.jain@intel.com>; Van Haaren, Harry > <harry.van.haaren@intel.com>; piotrx.t.azarewicz@intel.com > Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB an= d > EtherLike-MIB for e1000 >=20 > On Mon, 26 Jun 2017 10:42:13 +0100 > Radu Nicolau <radu.nicolau@intel.com> wrote: >=20 > > From: Michal Jastrzebski <michalx.k.jastrzebski@intel.com> > > > > If-MIB xstats: > > ifNumber > > ifIndex > > ifType > > ifMtu > > ifSpeed > > ifPhysAddress > > ifOperStatus > > ifLastChange > > ifHighSpeed > > ifConnectorPresent > > ifCounterDiscontinuityTime > > > > EtherLike-MIB xstats: > > dot3PauseOperMode > > dot3StatsDuplexStatus > > dot3StatsRateControlAbility > > dot3StatsRateControlStatus > > dot3ControlFunctionsSupported > > > > -updated in v2: coding style > > > > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com> > > Signed-off-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com> > > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> >=20 > Although this maybe the easiest way for Intel, and satisfy a specific use= r's > request. It is not a good way forward for the DPDK project. >=20 > This must be generic, not specific to device drivers. > If implementing a MIB variable requires more information than ethdev API > has now, then extend ethdev API first. >=20 Yes, most of the MIB attributes can be fetched from rte_eth_dev_data/rte_et= h_dev_info.=20 Re expressing my opinion (a) below which I did in other mail:=20 (a)For the MIB attributes which do not have any ethdev API support, how abo= ut getting all of them from PMDs via a new dev_op like xstats_get?.=20 Then add the new eth_dev API, which does call to this new dev_op and oth= er existing ethdev APIs to gather all mib information and expose that=20 to user based on port_id.=20 (Or) (b)Should we expand rte_eth_dev_info or rte_eth_dev_data to add missing mib= attributes, fetch them from PMDs using dev_infos_get() and expose to user. Adding new mib attributes to existing structs might need ABI break anno= uncements. =20 =20 But both cases (a) and (b) does need some PMD changes. Please let me know what you think about the points a and b. Thanks, Reshma