From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 7582F5592 for ; Tue, 20 Mar 2018 17:37:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2018 09:37:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,336,1517904000"; d="scan'208";a="36620245" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 20 Mar 2018 09:37:47 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Mar 2018 16:37:46 +0000 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.211]) by irsmsx112.ger.corp.intel.com ([169.254.1.226]) with mapi id 14.03.0319.002; Tue, 20 Mar 2018 16:37:46 +0000 From: "Pattan, Reshma" To: "Tan, Jianfeng" , "dev@dpdk.org" Thread-Topic: [PATCH] pdump: change to use generic multi-process channel Thread-Index: AQHTs8neFUbu0i76/UiWNBgJqZR5tqPZYd+g Date: Tue, 20 Mar 2018 16:37:45 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2B82D6@irsmsx110.ger.corp.intel.com> References: <1520175844-55443-1-git-send-email-jianfeng.tan@intel.com> In-Reply-To: <1520175844-55443-1-git-send-email-jianfeng.tan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] pdump: change to use generic multi-process channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 16:37:49 -0000 Hi, > -----Original Message----- > From: Tan, Jianfeng > Sent: Sunday, March 4, 2018 3:04 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Pattan, Reshma > > Subject: [PATCH] pdump: change to use generic multi-process channel >=20 > The original code replies on the private channel for primary and secondar= y > communication. Change to use the generic multi-process channel. >=20 > Note with this change, dpdk-pdump will be not compatible with old version > DPDK applications. >=20 Is this the correct time to make this change? As I see the rte_mp APIs are = still in experimental stage? If you wish to change them, 1) I feel ABI breakage has to be addressed first for change in rte_pdump_= init() . 2)ABI notice for removal of the rte_pdump_set_socket_dir() and then remove= it completely .=20 3)Need to do cleanup of the code app/dpdk-pdump.=20 4)After all the changes we need to make sure dpdk-pdump works fine without = breaking the functionality, validation team should be able to help. 5)Replace strcpy with snprintf. Thanks, Reshma