DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] pdump: change to use generic multi-process channel
Date: Tue, 27 Mar 2018 08:21:11 +0000	[thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2B9C38@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E36514A609C@SHSMSX103.ccr.corp.intel.com>

Hi,

> >
> > > > 1) I feel ABI breakage has to be addressed  first for change in
> > > rte_pdump_init() .
> >
> > So, you want to remove unnecessary socket  related code from
> > dpdk-pdump in future release itself?  Kind of making sense.
> > But dpdk-pdump  tool has socket path related command line options
> > which user still can pass on, isn't it kind of confusion we creating
> > w.r.t Internal design and usage?
> 
> AFAIK, these options do not affect anything with this patch even they are set.
> How about printing a warning saying that these options will be deprecated
> and take no effect now?

Fine I guess, when the ABI notice is sent to remove all socket path code, that time you can remove the socket path cli options too.

Thanks,
Reshma

  reply	other threads:[~2018-03-27  8:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-04 15:04 Jianfeng Tan
2018-03-20 16:37 ` Pattan, Reshma
2018-03-21  2:28   ` Tan, Jianfeng
2018-03-21  9:55     ` Pattan, Reshma
2018-03-27  1:26       ` Tan, Jianfeng
2018-03-27  8:21         ` Pattan, Reshma [this message]
2018-04-04 15:08 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan
2018-04-05  9:45   ` Pattan, Reshma
2018-04-05 12:02     ` Tan, Jianfeng
2018-04-05 10:37   ` Pattan, Reshma
2018-04-05 11:17     ` Tan, Jianfeng
2018-04-05 11:54 ` [dpdk-dev] [PATCH v3] " Jianfeng Tan
2018-04-05 12:28 ` [dpdk-dev] [PATCH v4] " Jianfeng Tan
2018-04-05 12:35   ` Pattan, Reshma
2018-04-17 23:11     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A2B9C38@irsmsx110.ger.corp.intel.com \
    --to=reshma.pattan@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).