From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id A51282B82 for ; Tue, 27 Mar 2018 10:21:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 01:21:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,366,1517904000"; d="scan'208";a="41563213" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga001.fm.intel.com with ESMTP; 27 Mar 2018 01:21:12 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 09:21:11 +0100 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.211]) by irsmsx112.ger.corp.intel.com ([169.254.1.226]) with mapi id 14.03.0319.002; Tue, 27 Mar 2018 09:21:11 +0100 From: "Pattan, Reshma" To: "Tan, Jianfeng" , "dev@dpdk.org" Thread-Topic: [PATCH] pdump: change to use generic multi-process channel Thread-Index: AQHTs8neFUbu0i76/UiWNBgJqZR5tqPZYd+ggACvHoCAAHoB0IAI0c8AgACB8RA= Date: Tue, 27 Mar 2018 08:21:11 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2B9C38@irsmsx110.ger.corp.intel.com> References: <1520175844-55443-1-git-send-email-jianfeng.tan@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2B82D6@irsmsx110.ger.corp.intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2B8602@irsmsx110.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] pdump: change to use generic multi-process channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 08:21:14 -0000 Hi, > > > > > > 1) I feel ABI breakage has to be addressed first for change in > > > rte_pdump_init() . > > > > So, you want to remove unnecessary socket related code from > > dpdk-pdump in future release itself? Kind of making sense. > > But dpdk-pdump tool has socket path related command line options > > which user still can pass on, isn't it kind of confusion we creating > > w.r.t Internal design and usage? >=20 > AFAIK, these options do not affect anything with this patch even they are= set. > How about printing a warning saying that these options will be deprecated > and take no effect now? Fine I guess, when the ABI notice is sent to remove all socket path code, t= hat time you can remove the socket path cli options too. Thanks, Reshma