From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 68DD829CB
 for <dev@dpdk.org>; Thu, 29 Mar 2018 12:48:18 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 29 Mar 2018 03:48:17 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208";a="39121400"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by orsmga003.jf.intel.com with ESMTP; 29 Mar 2018 03:48:16 -0700
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
 IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 29 Mar 2018 11:48:06 +0100
Received: from irsmsx110.ger.corp.intel.com ([169.254.15.211]) by
 IRSMSX156.ger.corp.intel.com ([169.254.3.229]) with mapi id 14.03.0319.002;
 Thu, 29 Mar 2018 11:48:05 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "adrien.mazarguil@6wind.com"
 <adrien.mazarguil@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Doherty, Declan"
 <declan.doherty@intel.com>, "Chandran, Sugesh" <sugesh.chandran@intel.com>,
 "Glynn, Michael J" <michael.j.glynn@intel.com>, "Liu, Yu Y"
 <yu.y.liu@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>, "Zhang, Qi Z"
 <qi.z.zhang@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 1/4] ether: add flow action to redirect
 packet in	a switch domain
Thread-Index: AQHTxyjAGHj3M/h770eAkgWSkm8L2qPnBmmA
Date: Thu, 29 Mar 2018 10:48:04 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2BAADF@irsmsx110.ger.corp.intel.com>
References: <1522279780-34842-1-git-send-email-qi.z.zhang@intel.com>
 <1522279780-34842-2-git-send-email-qi.z.zhang@intel.com>
In-Reply-To: <1522279780-34842-2-git-send-email-qi.z.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/4] ether: add flow action to redirect
 packet in	a switch domain
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Mar 2018 10:48:18 -0000

Hi=20

> Add action RTE_FLOW_ACTION_TYPE_SWITCH_PORT, it can be used to
> redirect a packet to a network interface that connect to the same switch
> domain, rte_ethdev's port_id is used as an identification of the destinat=
ion.
> A typical use case is: with a smart NIC for vSwitch acceleration, flow is=
 defined
> to forward packets between the switch port that is managed by Port
> Representor.
>=20

The macro name in commit message not matching with name in code.

> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  doc/guides/prog_guide/rte_flow.rst | 22 ++++++++++++++++++++++
>  lib/librte_ether/rte_flow.h        | 19 ++++++++++++++++++-
>  2 files changed, 40 insertions(+), 1 deletion(-)
>=20

I guess doc patch should be separated out and some typos in doc.

>  /**
> @@ -1148,6 +1155,16 @@ struct rte_flow_action_security {
>  	void *security_session; /**< Pointer to security session structure. */
> };
>=20
> +/** RTE_FLOW_ACTION_TYPE_PORT
> + *
> + * Redirect packets to a network interface in the same switch domain.
> + *
> + * Terminateing by default.

Typo..