From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 572982BB1
 for <dev@dpdk.org>; Thu, 29 Mar 2018 17:23:16 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 29 Mar 2018 08:23:15 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208";a="28032192"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by fmsmga007.fm.intel.com with ESMTP; 29 Mar 2018 08:23:14 -0700
Received: from irsmsx110.ger.corp.intel.com ([169.254.15.211]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.37]) with mapi id 14.03.0319.002;
 Thu, 29 Mar 2018 16:23:13 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "adrien.mazarguil@6wind.com"
 <adrien.mazarguil@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Doherty, Declan"
 <declan.doherty@intel.com>, "Chandran, Sugesh" <sugesh.chandran@intel.com>,
 "Glynn, Michael J" <michael.j.glynn@intel.com>, "Liu, Yu Y"
 <yu.y.liu@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>, "Zhang, Qi Z"
 <qi.z.zhang@intel.com>
Thread-Topic: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton
 in	flow API
Thread-Index: AQHTxyjTXmb2bs7KI0a/krWiRzCfXaPnUxTQ
Date: Thu, 29 Mar 2018 15:23:12 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2BBD18@irsmsx110.ger.corp.intel.com>
References: <1522279780-34842-1-git-send-email-qi.z.zhang@intel.com>
 <1522279780-34842-5-git-send-email-qi.z.zhang@intel.com>
In-Reply-To: <1522279780-34842-5-git-send-email-qi.z.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton
	in	flow API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Mar 2018 15:23:18 -0000

Hi,

> Subject: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in =
flow

Typo in the commit message header "action"

> +/** RTE_FLOW_ACTION_TYPE_FIELD_INCREMENT
> + *
> + * Increment 1 on specific field of the packet.
> + *
> + * Typical usage: increase TTL
> + */
> +struct rte_flow_action_field_increment {
> +	const struct rte_flow_item *item; /**< specify the data to modify. */
> +	uint8_t layer;
> +	/**< 0 means outermost matched pattern, 1 means next-to-
> outermost...
> +*/ };
> +
> +/** RTE_FLOW_ACTION_TYPE_FIELD_DECREMENT
> + *
> + * Decrement 1 on specific field of the packet.
> + *
> + * Typical usage: Decrease TTL
> + */
> +struct rte_flow_action_field_decrement {
> +	const struct rte_flow_item *item; /**< Specify the data to modify. */
> +	uint8_t layer;
> +	/**< 0 means outermost matched pattern, 1 means next-to-
> outermost...
> +*/ };
> +

Can you have only one  struct to represent both increment/decrements operat=
ions instead of two structs? As I see both use same data types .=20

Thanks,
Reshma