From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3463E1CA55 for ; Thu, 5 Apr 2018 11:46:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2018 02:46:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,410,1517904000"; d="scan'208";a="34500433" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 05 Apr 2018 02:46:07 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.211]) by IRSMSX102.ger.corp.intel.com ([169.254.2.164]) with mapi id 14.03.0319.002; Thu, 5 Apr 2018 10:45:38 +0100 From: "Pattan, Reshma" To: "Tan, Jianfeng" , "dev@dpdk.org" Thread-Topic: [PATCH v2] pdump: change to use generic multi-process channel Thread-Index: AQHTzCaF8wHSa3+lcUWs47gTF6O7p6Px3IbA Date: Thu, 5 Apr 2018 09:45:37 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2C023A@irsmsx110.ger.corp.intel.com> References: <1520175844-55443-1-git-send-email-jianfeng.tan@intel.com> <1522854488-59678-1-git-send-email-jianfeng.tan@intel.com> In-Reply-To: <1522854488-59678-1-git-send-email-jianfeng.tan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] pdump: change to use generic multi-process channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 09:46:09 -0000 Hi >=20 > Signed-off-by: Jianfeng Tan > --- > Note this patch needs this patch set: > http://dpdk.org/dev/patchwork/patch/36814/ > v2: > - Update doc for deprecation of API, rte_pdump_set_socket_dir, > and API change for rte_pdump_init. > - Add notice for known incompatibility issue in doc. > app/pdump/main.c | 6 +- > doc/guides/rel_notes/deprecation.rst | 4 + > doc/guides/rel_notes/release_18_05.rst | 7 + > lib/librte_pdump/Makefile | 3 +- > lib/librte_pdump/rte_pdump.c | 423 +++++----------------------= ------ > lib/librte_pdump/rte_pdump.h | 1 + > 6 files changed, 84 insertions(+), 360 deletions(-) >diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c > + >=20 > + > + /* recv client requests */ > + if (mp_msg->len_param !=3D sizeof(*cli_req)) { > + RTE_LOG(ERR, PDUMP, "failed to recv from client\n"); > + resp->err_value =3D EINVAL; resp->err_value =3D -EINVAL > - /* save the socket in local configuration */ > - pdump_socket_fd =3D socket_fd; > + snprintf(mp_resp.name, RTE_MP_MAX_NAME_LEN, PDUMP_MP); > + mp_resp.len_param =3D sizeof(*resp); > + mp_resp.num_fds =3D 0; > + if (rte_mp_reply(&mp_resp, peer) < 0) > + RTE_LOG(ERR, PDUMP, "failed to send to client:%s, %s:%d\n", > + strerror(rte_errno), __func__, __LINE__); >=20 If failed to send the reply should'nt we return -1?=20 > return 0; > } >=20 > int > -rte_pdump_set_socket_dir(const char *path, enum rte_pdump_socktype > type) > +rte_pdump_set_socket_dir(const char *path __rte_unused, > + enum rte_pdump_socktype type __rte_unused) > { What about enum rte_pdump_socktype in header file? When to delete them? We need to update doxygen comments in header file for rte_pdump_init and rt= e_pdump_uninit()? What do you say. Thanks, Reshma