From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3874A1CAD3 for ; Thu, 5 Apr 2018 12:37:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2018 03:37:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,410,1517904000"; d="scan'208";a="188863728" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga004.jf.intel.com with ESMTP; 05 Apr 2018 03:37:35 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.211]) by irsmsx105.ger.corp.intel.com ([169.254.7.216]) with mapi id 14.03.0319.002; Thu, 5 Apr 2018 11:37:34 +0100 From: "Pattan, Reshma" To: "Tan, Jianfeng" , "dev@dpdk.org" Thread-Topic: [PATCH v2] pdump: change to use generic multi-process channel Thread-Index: AQHTzCaF8wHSa3+lcUWs47gTF6O7p6Px+ujg Date: Thu, 5 Apr 2018 10:37:34 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2C0302@irsmsx110.ger.corp.intel.com> References: <1520175844-55443-1-git-send-email-jianfeng.tan@intel.com> <1522854488-59678-1-git-send-email-jianfeng.tan@intel.com> In-Reply-To: <1522854488-59678-1-git-send-email-jianfeng.tan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] pdump: change to use generic multi-process channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 10:37:37 -0000 Hi, > -----Original Message----- > From: Tan, Jianfeng > Sent: Wednesday, April 4, 2018 4:08 PM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Pattan, Reshma > > Subject: [PATCH v2] pdump: change to use generic multi-process channel >=20 > The original code replies on the private channel for primary and secondar= y > communication. Change to use the generic multi-process channel. >=20 > Note with this change, dpdk-pdump will be not compatible with old version > DPDK applications. >=20 > Cc: reshma.pattan@intel.com >=20 > Signed-off-by: Jianfeng Tan > --- > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 0c696f7..d55fd05 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -153,3 +153,7 @@ Deprecation Notices > be added between the producer and consumer structures. The size of the > structure and the offset of the fields will remain the same on > platforms with 64B cache line, but will change on other platforms. > + > +* pdump: As we changed to use generic IPC, ``rte_pdump_set_socket_dir`` > +will be > + deprecated and removed in subsequent release; the parameter, path, of > + ``rte_pdump_init`` will also be removed. Do we need to mention about deprecation of below enums too? enum rte_pdump_socktype { RTE_PDUMP_SOCKET_SERVER =3D 1, RTE_PDUMP_SOCKET_CLIENT =3D 2 }; Thanks, Reshma