From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id C17FE271
 for <dev@dpdk.org>; Tue, 24 Apr 2018 13:23:27 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 24 Apr 2018 04:23:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,322,1520924400"; d="scan'208";a="36594175"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by orsmga006.jf.intel.com with ESMTP; 24 Apr 2018 04:23:25 -0700
Received: from irsmsx110.ger.corp.intel.com ([169.254.15.211]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.171]) with mapi id 14.03.0319.002;
 Tue, 24 Apr 2018 12:23:24 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>
CC: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Hunt, David" <david.hunt@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit tests
Thread-Index: AQHT0Z98jkrk1WfVkkOj9htwKVuCGaQO2VGAgADpKoCAABaW0A==
Date: Tue, 24 Apr 2018 11:23:23 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2C9022@irsmsx110.ger.corp.intel.com>
References: <1523022706-12231-1-git-send-email-reshma.pattan@intel.com>
 <1523456067-14178-1-git-send-email-reshma.pattan@intel.com>
 <3442093.nS8Mgo2NPm@xps>
 <20180424105859.GA124204@bricha3-MOBL.ger.corp.intel.com>
In-Reply-To: <20180424105859.GA124204@bricha3-MOBL.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit tests
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2018 11:23:28 -0000

Hi,

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, April 24, 2018 11:59 AM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
> dev@dpdk.org; Pattan, Reshma <reshma.pattan@intel.com>; Hunt, David
> <david.hunt@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit
> tests
>=20
> On Mon, Apr 23, 2018 at 11:04:27PM +0200, Thomas Monjalon wrote:
> > 11/04/2018 16:14, Reshma Pattan:
> > > Unit Testcases are added for power_acpi_cpu_freq, power_kvm_vm_test
> > > to improve coverage
> > >
> > > Signed-off-by: Jananee Parthasarathy
> > > <jananeex.m.parthasarathy@intel.com>
> > > Acked-by: David Hunt <david.hunt@intel.com>
> >
> > Applied, thanks
> >
> Sadly, this patch seems to break shared library builds. If you try doing =
"make
> test-build" with shared libraries on it will fail, or if you do a meson b=
uild using
> shared libraries you will get the same result.
>=20
> The root cause is that the function guest_channel_host_connect() is a pri=
vate
> function and so is not listed in the shared library map file, preventing =
the test
> app from linking.
>=20

Any action from my side required? Let me know.

> Regards,
> /Bruce