From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DF6001BA94; Thu, 10 May 2018 14:24:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2018 05:24:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,385,1520924400"; d="scan'208";a="40164115" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga008.jf.intel.com with ESMTP; 10 May 2018 05:24:05 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 10 May 2018 13:24:04 +0100 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.125]) by IRSMSX156.ger.corp.intel.com ([169.254.3.233]) with mapi id 14.03.0319.002; Thu, 10 May 2018 13:24:04 +0100 From: "Pattan, Reshma" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/vhost_scsi: replace strncpy with strlcpy Thread-Index: AQHT54ndqpFIqMRkCEyovwTc3hgjbaQnVeiAgAGOPPA= Date: Thu, 10 May 2018 12:24:02 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2EF50B@irsmsx110.ger.corp.intel.com> References: <1525865729-16086-1-git-send-email-reshma.pattan@intel.com> <1525865729-16086-3-git-send-email-reshma.pattan@intel.com> <20180509133729.GB25048@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180509133729.GB25048@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/vhost_scsi: replace strncpy with strlcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 12:24:07 -0000 Hi Bruce, > Can the magic numbers "32", "8", "4" be replaced with non-magic values, e= .g. > sizeof(...). >=20 This is now taken care wherever possible in latest patch. Thanks, Reshma > /Bruce