From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Hunt, David" <david.hunt@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Hunt, David" <david.hunt@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test
Date: Thu, 10 May 2018 15:25:00 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2EF706@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <20180510073815.76926-1-david.hunt@intel.com>
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
> Sent: Thursday, May 10, 2018 8:38 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Hunt, David
> <david.hunt@intel.com>
> Subject: [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test
>
> New warning with gcc 8.1:
> The table_action_stub_miss() function was incorrectly declared as returning a
> typedef of rte_pipeline_table_action_handler_miss, instead of what it should
> have been, an int.
> Changed this to declare the function as returning an int, and now when the
> action_handler_miss is set to table_action_stub_miss (cast as
> rte_pipeline_table_action_handler_miss), gcc 8.1 no longer complains about
> the cast.
>
> Fixes: 5205954791cb ("app/test: packet framework unit tests")
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
Looks ok to me.
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
next prev parent reply other threads:[~2018-05-10 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 7:38 David Hunt
2018-05-10 15:25 ` Pattan, Reshma [this message]
2018-05-11 15:42 ` De Lara Guarch, Pablo
2018-05-13 21:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A2EF706@irsmsx110.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).