From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B1FEE1BB67 for ; Thu, 10 May 2018 17:25:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2018 08:25:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,385,1520924400"; d="scan'208";a="54795844" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 10 May 2018 08:25:02 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.125]) by IRSMSX103.ger.corp.intel.com ([169.254.3.179]) with mapi id 14.03.0319.002; Thu, 10 May 2018 16:25:01 +0100 From: "Pattan, Reshma" To: "Hunt, David" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" , "Hunt, David" Thread-Topic: [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test Thread-Index: AQHT6Gy/ZxQEehWFzECqHPn9L2be2qQpFQQg Date: Thu, 10 May 2018 15:25:00 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2EF706@irsmsx110.ger.corp.intel.com> References: <20180510073815.76926-1-david.hunt@intel.com> In-Reply-To: <20180510073815.76926-1-david.hunt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 15:25:05 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt > Sent: Thursday, May 10, 2018 8:38 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Hunt, David > > Subject: [dpdk-dev] [PATCH] test: fix incorrect cast in pipeline unit tes= t >=20 > New warning with gcc 8.1: > The table_action_stub_miss() function was incorrectly declared as returni= ng a > typedef of rte_pipeline_table_action_handler_miss, instead of what it sho= uld > have been, an int. > Changed this to declare the function as returning an int, and now when th= e > action_handler_miss is set to table_action_stub_miss (cast as > rte_pipeline_table_action_handler_miss), gcc 8.1 no longer complains abou= t > the cast. >=20 > Fixes: 5205954791cb ("app/test: packet framework unit tests") >=20 > Signed-off-by: David Hunt Looks ok to me. Reviewed-by: Reshma Pattan