From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 5F3D81B967;
 Tue, 15 May 2018 07:59:35 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 14 May 2018 22:59:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,402,1520924400"; d="scan'208";a="55263597"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by fmsmga001.fm.intel.com with ESMTP; 14 May 2018 22:59:33 -0700
Received: from irsmsx110.ger.corp.intel.com ([169.254.15.125]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.96]) with mapi id 14.03.0319.002;
 Tue, 15 May 2018 06:59:32 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Michal Jastrzebski
 <michalx.k.jastrzebski@intel.com>, Jacek Piasecki <jacekx.piasecki@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "yliu@fridaylinux.org"
 <yliu@fridaylinux.org>, "maxime.coquelin@redhat.com"
 <maxime.coquelin@redhat.com>, "Jain, Deepak K" <deepak.k.jain@intel.com>,
 "Liu, Changpeng" <changpeng.liu@intel.com>, "stable@dpdk.org"
 <stable@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated
Thread-Index: AQHTM6QlbOCwHJgqHkK8s3uZS5NC3KQw9b0AgADFY2A=
Date: Tue, 15 May 2018 05:59:31 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A2F0E17@irsmsx110.ger.corp.intel.com>
References: <20170922130959.13484-1-michalx.k.jastrzebski@intel.com>
 <1932528.5N0iXfLR29@xps>
In-Reply-To: <1932528.5N0iXfLR29@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not
 terminated
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 15 May 2018 05:59:35 -0000

Hi Thomas,

> Can it be fixed with strlcpy?
>=20
> I wonder why recent patch from Reshma is not touching these lines:
> 	http://dpdk.org/commit/21ce8e44b8d
>=20

Yes, I remembered now, I fixed only gcc 8.0.1 compilation issues of this fi=
le, in which the lines of  code this patch
is fixing is not listed. I totally forgot to replace these lines with strlc=
py later on.

Thanks,
Reshma