From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id AF6311B3A8 for ; Thu, 12 Jul 2018 18:00:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2018 09:00:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,343,1526367600"; d="scan'208";a="66440781" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga003.jf.intel.com with ESMTP; 12 Jul 2018 09:00:24 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 12 Jul 2018 17:00:23 +0100 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.124]) by irsmsx111.ger.corp.intel.com ([169.254.2.118]) with mapi id 14.03.0319.002; Thu, 12 Jul 2018 17:00:23 +0100 From: "Pattan, Reshma" To: "Parthasarathy, JananeeX M" , "dev@dpdk.org" CC: "Horton, Remy" , "Chaitanya Babu, TalluriX" Thread-Topic: [PATCH v2] add sample functions for packet forwarding Thread-Index: AQHUGb3MpZIxHRma50WLqBxUXT1B1aSLukmw Date: Thu, 12 Jul 2018 16:00:22 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3701CE@IRSMSX109.ger.corp.intel.com> References: <1530896835-19629-1-git-send-email-jananeex.m.parthasarathy@intel.com> <1531385584-24545-1-git-send-email-jananeex.m.parthasarathy@intel.com> In-Reply-To: <1531385584-24545-1-git-send-email-jananeex.m.parthasarathy@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] add sample functions for packet forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 16:00:27 -0000 Hi Jananee, > -----Original Message----- > From: Parthasarathy, JananeeX M > Sent: Thursday, July 12, 2018 9:53 AM > To: dev@dpdk.org > Cc: Horton, Remy ; Pattan, Reshma > ; Parthasarathy, JananeeX M > ; Chaitanya Babu, TalluriX > > Subject: [PATCH v2] add sample functions for packet forwarding >=20 I could apply the patch succefully but there was a warning, just check is = the white line can be removed. git apply v2-add-sample-functions-for-packet-forwarding v2-add-sample-functions-for-packet-forwarding:160: new blank line at EOF. + warning: 1 line adds whitespace errors. > + uint16_t socket_id =3D rte_socket_id(); > + struct rte_ring *rxtx[NUM_RINGS]; > + rxtx[0] =3D rte_ring_create("R0", RING_SIZE, socket_id, > + RING_F_SP_ENQ|RING_F_SC_DEQ); > + if (rxtx[0] =3D=3D NULL) { > + printf("%s() line %u: rte_ring_create R0 failed", > + __func__, __LINE__); > + return TEST_FAILED; > + } > + rxtx[1] =3D rte_ring_create("R1", RING_SIZE, socket_id, > + RING_F_SP_ENQ|RING_F_SC_DEQ); > + if (rxtx[1] =3D=3D NULL) { > + printf("%s() line %u: rte_ring_create R1 failed", > + __func__, __LINE__); > + return TEST_FAILED; > + } > + tx_portid =3D rte_eth_from_rings("net_ringa", rxtx, NUM_QUEUES, rxtx, > + NUM_QUEUES, socket_id); > + rx_portid =3D rte_eth_from_rings("net_ringb", rxtx, NUM_QUEUES, rxtx, > + NUM_QUEUES, socket_id); Also can you see if you can create only one port using rings instead of 2 a= nd use it for=20 two ports rx_port id and tx_ports ids? And will that fit for all the UTs t= hat you are writing. Thanks, Reshma