From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Somarowthu, Naga SureshX" <naga.sureshx.somarowthu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>
Subject: Re: [dpdk-dev] [PATCH v9 3/5] test: add unit tests for latencystats library
Date: Tue, 31 Jul 2018 22:20:24 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A377F35@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <2377661.dBTvqWlEOu@xps>
Hi,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, July 31, 2018 6:06 PM
> To: Pattan, Reshma <reshma.pattan@intel.com>; Somarowthu, Naga SureshX
> <naga.sureshx.somarowthu@intel.com>
> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>;
> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v9 3/5] test: add unit tests for latencystats
> library
>
> 31/07/2018 18:40, Reshma Pattan:
> > From: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
> >
> > Unit Test Cases added for latencystats library.
> >
> > Signed-off-by: Naga Suresh Somarowthu
> <naga.sureshx.somarowthu@intel.com>
> > Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> > ---
>
> Compilation error with clang:
>
> > + struct rte_metric_name names[NUM_STATS] = { 0 };
>
> test_latencystats.c:73:46: fatal error:
> suggest braces around initialization of subobject [-Wmissing-braces]
>
> > + struct rte_metric_name wrongnames[NUM_STATS - 2] = { 0 };
>
> Usually, it is recommended to use memset for initializations of structs.
>
Fixed in v10 .
Thanks,
Reshma
next prev parent reply other threads:[~2018-07-31 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 16:40 [dpdk-dev] [PATCH v9 0/5] add unit tests for bitrate, latency and pdump libraries Reshma Pattan
2018-07-31 16:40 ` [dpdk-dev] [PATCH v9 1/5] test: add helper functions for tests using ring-PMD Rx/Tx Reshma Pattan
2018-07-31 16:40 ` [dpdk-dev] [PATCH v9 2/5] test: add unit tests for bitrate library Reshma Pattan
2018-07-31 16:40 ` [dpdk-dev] [PATCH v9 3/5] test: add unit tests for latencystats library Reshma Pattan
2018-07-31 17:05 ` Thomas Monjalon
2018-07-31 22:20 ` Pattan, Reshma [this message]
2018-07-31 16:40 ` [dpdk-dev] [PATCH v9 4/5] test: add unit test for pdump library Reshma Pattan
2018-07-31 16:40 ` [dpdk-dev] [PATCH v9 5/5] autotest: add new unit tests to autotest list Reshma Pattan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A377F35@IRSMSX109.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=naga.sureshx.somarowthu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).