From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id D093D4CBB
 for <dev@dpdk.org>; Wed,  1 Aug 2018 00:20:27 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 31 Jul 2018 15:20:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,429,1526367600"; d="scan'208";a="61032983"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by orsmga007.jf.intel.com with ESMTP; 31 Jul 2018 15:20:25 -0700
Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by
 IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Tue, 31 Jul 2018 23:20:24 +0100
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.124]) by
 irsmsx111.ger.corp.intel.com ([169.254.2.118]) with mapi id 14.03.0319.002;
 Tue, 31 Jul 2018 23:20:25 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Somarowthu, Naga SureshX"
 <naga.sureshx.somarowthu@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Burakov, Anatoly"
 <anatoly.burakov@intel.com>, "Parthasarathy, JananeeX M"
 <jananeex.m.parthasarathy@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v9 3/5] test: add unit tests for
 latencystats library
Thread-Index: AQHUKPDC2xs0tuujNkKHun1vdYbdLKSp50lw
Date: Tue, 31 Jul 2018 22:20:24 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A377F35@IRSMSX109.ger.corp.intel.com>
References: <1533055256-10317-1-git-send-email-reshma.pattan@intel.com>
 <1533055256-10317-4-git-send-email-reshma.pattan@intel.com>
 <2377661.dBTvqWlEOu@xps>
In-Reply-To: <2377661.dBTvqWlEOu@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v9 3/5] test: add unit tests for latencystats
 library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 22:20:28 -0000

Hi,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, July 31, 2018 6:06 PM
> To: Pattan, Reshma <reshma.pattan@intel.com>; Somarowthu, Naga SureshX
> <naga.sureshx.somarowthu@intel.com>
> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>;
> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v9 3/5] test: add unit tests for latencyst=
ats
> library
>=20
> 31/07/2018 18:40, Reshma Pattan:
> > From: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
> >
> > Unit Test Cases added for latencystats library.
> >
> > Signed-off-by: Naga Suresh Somarowthu
> <naga.sureshx.somarowthu@intel.com>
> > Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> > ---
>=20
> Compilation error with clang:
>=20
> > +	struct rte_metric_name names[NUM_STATS] =3D { 0 };
>=20
> test_latencystats.c:73:46: fatal error:
> suggest braces around initialization of subobject [-Wmissing-braces]
>=20
> > +	struct rte_metric_name wrongnames[NUM_STATS - 2] =3D { 0 };
>=20
> Usually, it is recommended to use memset for initializations of structs.
>=20

Fixed in v10 .

Thanks,
Reshma