From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Chaitanya Babu, TalluriX" <tallurix.chaitanya.babu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test: restructure and cleanup ring PMD test
Date: Wed, 26 Sep 2018 09:38:35 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A39EDBB@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1537449810-23573-1-git-send-email-jananeex.m.parthasarathy@intel.com>
> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Thursday, September 20, 2018 2:24 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Chaitanya Babu, TalluriX
> <tallurix.chaitanya.babu@intel.com>
> Subject: [PATCH] test: restructure and cleanup ring PMD test
>
> From: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
>
> Divided main test to smaller logical tests.
> Registered with UT framework.
> Added cleanup of the resources else ring creation fails during consecutive test
> runs.
> Freed the allocated mempool, rings and uninitalized the drivers.
>
> static int
> @@ -212,7 +214,7 @@ test_stats_reset(int port) }
>
> static int
> -test_pmd_ring_pair_create_attach(int portd, int porte)
> +test_pmd_ring_pair_create_attach(void)
> {
> struct rte_eth_stats stats, stats2;
> struct rte_mbuf buf, *pbuf = &buf;
> @@ -220,185 +222,217 @@ test_pmd_ring_pair_create_attach(int portd, int
> porte)
>
> memset(&null_conf, 0, sizeof(struct rte_eth_conf));
>
> - if ((rte_eth_dev_configure(portd, 1, 1, &null_conf) < 0)
> - || (rte_eth_dev_configure(porte, 1, 1, &null_conf) < 0)) {
> + if ((rte_eth_dev_configure(rxtx_portd, 1, 1, &null_conf) < 0)
> + || (rte_eth_dev_configure(rxtx_porte, 1, 1, &null_conf) < 0)) {
Small nits:
Here and in other places, as per coding guidelines the continuation of
if statement should be at 2 tabs . Please refer guidelines.
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
next prev parent reply other threads:[~2018-09-26 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 13:23 Jananee Parthasarathy
2018-09-20 14:07 ` Parthasarathy, JananeeX M
2018-09-26 9:38 ` Pattan, Reshma [this message]
2018-09-26 13:11 ` [dpdk-dev] [PATCH v2] " Jananee Parthasarathy
2018-10-09 9:07 ` Pattan, Reshma
2018-10-29 2:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A39EDBB@IRSMSX109.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=tallurix.chaitanya.babu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).