From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id 8359C1B119
for <dev@dpdk.org>; Wed, 26 Sep 2018 11:42:09 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
26 Sep 2018 02:42:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,305,1534834800"; d="scan'208";a="92006290"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
by fmsmga004.fm.intel.com with ESMTP; 26 Sep 2018 02:38:36 -0700
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.156]) by
IRSMSX103.ger.corp.intel.com ([169.254.3.248]) with mapi id 14.03.0319.002;
Wed, 26 Sep 2018 10:38:36 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
CC: "Chaitanya Babu, TalluriX" <tallurix.chaitanya.babu@intel.com>
Thread-Topic: [PATCH] test: restructure and cleanup ring PMD test
Thread-Index: AQHUUOU2nLzf7jTQyku0AmCcx/9muaUCVrGg
Date: Wed, 26 Sep 2018 09:38:35 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A39EDBB@IRSMSX109.ger.corp.intel.com>
References: <1537449810-23573-1-git-send-email-jananeex.m.parthasarathy@intel.com>
In-Reply-To: <1537449810-23573-1-git-send-email-jananeex.m.parthasarathy@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] test: restructure and cleanup ring PMD test
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2018 09:42:10 -0000
> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Thursday, September 20, 2018 2:24 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Chaitanya Babu, TalluriX
> <tallurix.chaitanya.babu@intel.com>
> Subject: [PATCH] test: restructure and cleanup ring PMD test
>=20
> From: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
>=20
> Divided main test to smaller logical tests.
> Registered with UT framework.
> Added cleanup of the resources else ring creation fails during consecutiv=
e test
> runs.
> Freed the allocated mempool, rings and uninitalized the drivers.
>=20
> static int
> @@ -212,7 +214,7 @@ test_stats_reset(int port) }
>=20
> static int
> -test_pmd_ring_pair_create_attach(int portd, int porte)
> +test_pmd_ring_pair_create_attach(void)
> {
> struct rte_eth_stats stats, stats2;
> struct rte_mbuf buf, *pbuf =3D &buf;
> @@ -220,185 +222,217 @@ test_pmd_ring_pair_create_attach(int portd, int
> porte)
>=20
> memset(&null_conf, 0, sizeof(struct rte_eth_conf));
>=20
> - if ((rte_eth_dev_configure(portd, 1, 1, &null_conf) < 0)
> - || (rte_eth_dev_configure(porte, 1, 1, &null_conf) < 0)) {
> + if ((rte_eth_dev_configure(rxtx_portd, 1, 1, &null_conf) < 0)
> + || (rte_eth_dev_configure(rxtx_porte, 1, 1, &null_conf) < 0)) {
Small nits:
Here and in other places, as per coding guidelines the continuation of
if statement should be at 2 tabs . Please refer guidelines.
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>