From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 474CB7CE2 for ; Thu, 25 Oct 2018 17:18:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 08:18:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,424,1534834800"; d="scan'208";a="85544765" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga006.jf.intel.com with ESMTP; 25 Oct 2018 08:18:50 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.182]) by IRSMSX101.ger.corp.intel.com ([169.254.1.4]) with mapi id 14.03.0319.002; Thu, 25 Oct 2018 16:18:49 +0100 From: "Pattan, Reshma" To: "Varghese, Vipin" , "dev@dpdk.org" , "Tahhan, Maryam" CC: "Patel, Amol" , "Tummala, Sivaprasad" , "Byrne, Stephen1" , "Glynn, Michael J" Thread-Topic: [PATCH v1 2/9] app/procinfo: add compare for new options Thread-Index: AQHUatj5/q7JTphJ5Eqo9vhUk+xJ/aUwFRwQ Date: Thu, 25 Oct 2018 15:18:48 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3BE084@irsmsx110.ger.corp.intel.com> References: <20181023135751.21536-1-vipin.varghese@intel.com> <20181023135751.21536-2-vipin.varghese@intel.com> In-Reply-To: <20181023135751.21536-2-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 2/9] app/procinfo: add compare for new options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 15:18:52 -0000 > -----Original Message----- > From: Varghese, Vipin > +/**< Enable port debug. */ In comment , Enable displaying port info? > +static uint32_t enable_dbg_port; Do you want to consider replacing "debug" to "show" in code here other plac= es? As you have already changed the commands to "show." ring_name =3D optarg; How about doing memcpy instead of pointer assignment? Similarly below. Thou= gh I don't see issue here. But safe to use memcpy. > + } else if (!strncmp(long_option[option_index].name, > + "dbg-mempool", > MAX_LONG_OPT_SZ)) { > + enable_dbg_mempool =3D 1; > + mempool_name =3D optarg; > + } Thanks, Reshma