From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id A4B862E81
 for <dev@dpdk.org>; Fri, 26 Oct 2018 15:02:02 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 26 Oct 2018 06:02:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,428,1534834800"; d="scan'208";a="102894373"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by orsmga001.jf.intel.com with ESMTP; 26 Oct 2018 06:02:00 -0700
Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by
 IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Fri, 26 Oct 2018 14:01:59 +0100
Received: from irsmsx110.ger.corp.intel.com ([169.254.15.182]) by
 irsmsx155.ger.corp.intel.com ([169.254.14.27]) with mapi id 14.03.0319.002;
 Fri, 26 Oct 2018 14:01:59 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "Tahhan, Maryam" <maryam.tahhan@intel.com>
CC: "Patel, Amol" <amol.patel@intel.com>, "Tummala, Sivaprasad"
 <sivaprasad.tummala@intel.com>, "Byrne, Stephen1" <stephen1.byrne@intel.com>, 
 "Glynn, Michael J" <michael.j.glynn@intel.com>
Thread-Topic: [PATCH v2 6/9] app/procinfo: add code for debug crypto
Thread-Index: AQHUa2YcP7iXKYAxjUSoh7r4XPxixaUxf7lA
Date: Fri, 26 Oct 2018 13:01:58 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3BE6A5@irsmsx110.ger.corp.intel.com>
References: <20181023135751.21536-1-vipin.varghese@intel.com>
 <20181024064805.23197-1-vipin.varghese@intel.com>
 <20181024064805.23197-6-vipin.varghese@intel.com>
In-Reply-To: <20181024064805.23197-6-vipin.varghese@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzk2MDQwM2QtMzY2ZS00M2NlLTg4YjEtYmViNTBhNGIyMjk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOVBRU3YwcXNJdEl4WDEzTTVyTm40bjJsXC9pcVhSeE56WG1US0RMVVJ6RFNEcTROa0NTNWJSTzZ4RzZ3OUNcL0lKIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug
	crypto
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Oct 2018 13:02:03 -0000

Hi

-----Original Message-----
From: Varghese, Vipin=20

---
+		struct rte_cryptodev_info dev_info =3D {0};
+		struct rte_cryptodev_stats stats =3D {0};
+

Memset for initialization as mentioned in other patch.

+
+#define DSP_CRYPTO_FLAG(x) do { \
+printf("  - feature flags\n"); \
+printf("\t  -- symmetric (%c) asymmetric (%c)" \ " symmetric operation=20
+chaining (%c)\n", \ (x & RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO)?'y':'n', \=20
+(x & RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO)?'y':'n', \ (x &=20
+RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING)?'y':'n'); \ printf("\t  -- CPU=20
+SSE (%c) AVX (%c) AVX2 (%c) AVX512 (%c)\n", \ (x &=20
+RTE_CRYPTODEV_FF_CPU_SSE)?'y':'n', \ (x &=20
+RTE_CRYPTODEV_FF_CPU_AVX)?'y':'n', \ (x &=20
+RTE_CRYPTODEV_FF_CPU_AVX2)?'y':'n', \ (x &=20
+RTE_CRYPTODEV_FF_CPU_AVX512)?'y':'n'); \ printf("\t  -- Acclerate CPU=20
+AESNI (%c) HW (%c)\n", \ (x & RTE_CRYPTODEV_FF_CPU_AESNI)?'y':'n', \ (x=20
+& RTE_CRYPTODEV_FF_HW_ACCELERATED)?'y':'n'); \ printf("\t  -- INLINE=20
+(%c)\n", \ (x & RTE_CRYPTODEV_FF_SECURITY)?'y':'n'); \ printf("\t  --=20
+ARM NEON (%c) CE (%c)\n", \ (x & RTE_CRYPTODEV_FF_CPU_NEON)?'y':'n', \=20
+(x & RTE_CRYPTODEV_FF_CPU_ARM_CE)?'y':'n'); \ printf("  - buffer=20
+offload\n"); \ printf("\t  -- IN_PLACE_SGL (%c)\n", \ (x &=20
+RTE_CRYPTODEV_FF_IN_PLACE_SGL)?'y':'n'); \ printf("\t  --=20
+OOP_SGL_IN_SGL_OUT (%c)\n", \ (x &=20
+RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)?'y':'n'); \ printf("\t  --=20
+OOP_SGL_IN_LB_OUT (%c)\n", \ (x &=20
+RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)?'y':'n'); \ printf("\t  --=20
+OOP_LB_IN_SGL_OUT (%c)\n", \ (x &=20
+RTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT)?'y':'n'); \ printf("\t  --=20
+OOP_LB_IN_LB_OUT (%c)\n", \ (x &=20
+RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT)?'y':'n'); \ } while (0)

This is a very big macro, better have static function for this instead of m=
acro.

 Thanks,
Reshma