From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Li Han <han.li1@zte.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/proc-info:fix port mask parse bug
Date: Tue, 6 Nov 2018 10:39:20 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3D0D0D@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <1541473466-27118-1-git-send-email-han.li1@zte.com.cn>
Hi,
> -----Original Message-----
> From: Li Han [mailto:han.li1@zte.com.cn]
> Sent: Tuesday, November 6, 2018 3:04 AM
> To: Pattan, Reshma <reshma.pattan@intel.com>
> Cc: dev@dpdk.org; Li Han <han.li1@zte.com.cn>
> Subject: [PATCH v2] [dpdk-dev] app/proc-info:fix port mask parse bug
>
> parse_portmask return type is int,but global variable "enabled_port_mask" type
> is uint32_t.so in proc_info_parse_args function,when parse_portmask return -
> 1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask == 0)"
> will never happen.
1) Please add Fixes line for the commit id that introduced this bug.
Refer below link to know more on Fixes line, http://doc.dpdk.org/guides/contributing/patches.html
Ex: Fixes: commit id ("commit message")
2) Title of the patch just can be "fix port mask parsing". No need to say bug.
And give space after ': ' in the heading.
When I ran below script after applying your patches above 2 issues been reported, so you should make sure to run the below script before sending the patch.
$devtools/check-git-log.sh
Wrong headline format:
app/proc-info:fix port mask parse bug
Missing 'Fixes' tag:
app/proc-info:fix port mask parse bug
Other than that , Please keep my ack in next version
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Thanks,
Reshma
prev parent reply other threads:[~2018-11-06 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 3:04 Li Han
2018-11-06 10:39 ` Pattan, Reshma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A3D0D0D@irsmsx110.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=dev@dpdk.org \
--cc=han.li1@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).