From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 056152C52 for ; Tue, 6 Nov 2018 11:39:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2018 02:39:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,471,1534834800"; d="scan'208";a="105674132" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 06 Nov 2018 02:39:22 -0800 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.20]) by IRSMSX102.ger.corp.intel.com ([169.254.2.13]) with mapi id 14.03.0415.000; Tue, 6 Nov 2018 10:39:21 +0000 From: "Pattan, Reshma" To: Li Han CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] [dpdk-dev] app/proc-info:fix port mask parse bug Thread-Index: AQHUdYHt2AP0MkytMEuP3n8b8vk9kKVCg2Cg Date: Tue, 6 Nov 2018 10:39:20 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3D0D0D@irsmsx110.ger.corp.intel.com> References: <1541473466-27118-1-git-send-email-han.li1@zte.com.cn> In-Reply-To: <1541473466-27118-1-git-send-email-han.li1@zte.com.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTEzY2Y2ZTUtYmZmOS00OTRjLThkYzgtMDU2ZGI5MjdhYjA2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTHBDSm1cLzV4ZWlhSFR2SmIzOWNtZ3g2dzFpYWNjZnRabngzMm9QU3dWb1J5V1NUcUFRWVFzNnNOeEhZSzgzdmQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/proc-info:fix port mask parse bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 10:39:24 -0000 Hi, > -----Original Message----- > From: Li Han [mailto:han.li1@zte.com.cn] > Sent: Tuesday, November 6, 2018 3:04 AM > To: Pattan, Reshma > Cc: dev@dpdk.org; Li Han > Subject: [PATCH v2] [dpdk-dev] app/proc-info:fix port mask parse bug >=20 > parse_portmask return type is int,but global variable "enabled_port_mask"= type > is uint32_t.so in proc_info_parse_args function,when parse_portmask retur= n - > 1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask = =3D=3D 0)" > will never happen. 1) Please add Fixes line for the commit id that introduced this bug.=20 Refer below link to know more on Fixes line, http://doc.dpdk.org/guides/co= ntributing/patches.html Ex: Fixes: commit id ("commit message") 2) Title of the patch just can be "fix port mask parsing". No need to say= bug.=20 And give space after ': ' in the heading. When I ran below script after applying your patches above 2 issues been rep= orted, so you should make sure to run the below script before sending the p= atch.=20 $devtools/check-git-log.sh Wrong headline format: app/proc-info:fix port mask parse bug Missing 'Fixes' tag: app/proc-info:fix port mask parse bug Other than that , Please keep my ack in next version Acked-by: Reshma Pattan Thanks, Reshma