From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D51165F2C for ; Wed, 21 Nov 2018 15:24:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2018 06:24:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,261,1539673200"; d="scan'208";a="97999796" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 21 Nov 2018 06:24:19 -0800 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.20]) by IRSMSX103.ger.corp.intel.com ([169.254.3.253]) with mapi id 14.03.0415.000; Wed, 21 Nov 2018 14:24:18 +0000 From: "Pattan, Reshma" To: "Varghese, Vipin" , "dev@dpdk.org" , "thomas@monjalon.net" , "stephen@networkplumber.org" , "Mcnamara, John" CC: "Byrne, Stephen1" , "Glynn, Michael J" , "Patel, Amol" Thread-Topic: [PATCH v4 4/9] app/procinfo: add support for show port Thread-Index: AQHUdc+yZXRWKa5OekS3TfO+mWSH96VaXfTA Date: Wed, 21 Nov 2018 14:24:18 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3D5888@irsmsx110.ger.corp.intel.com> References: <20181106124912.40700-1-vipin.varghese@intel.com> <20181106124912.40700-4-vipin.varghese@intel.com> In-Reply-To: <20181106124912.40700-4-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2RlNTM2NjQtZjEwOS00Y2ZmLTk1ZDItY2IzZjdmNzdkMjQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUHlQb2E1OVdDVHFySzZnZFZZdGYzRWRJd3M0STFwNSt1MXk0Nlwvd0prOSs2aHRVTjFpRCtQRkluSXFyMEoyVngifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/9] app/procinfo: add support for show port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 14:24:22 -0000 > -----Original Message----- > From: Varghese, Vipin > Sent: Tuesday, November 6, 2018 12:49 PM > To: dev@dpdk.org; thomas@monjalon.net; Pattan, Reshma > ; stephen@networkplumber.org; Mcnamara, John > > Cc: Byrne, Stephen1 ; Glynn, Michael J > ; Patel, Amol ; Varghese= , > Vipin > Subject: [PATCH v4 4/9] app/procinfo: add support for show port > + snprintf(bdr_str, 100, " Port (%u)", i); %s/100/MAX_STRING_LEN ? > + ret =3D rte_eth_dev_rss_hash_conf_get(i, &rss_conf); > + if ((ret) || (rss_conf.rss_key =3D=3D NULL)) > + continue; > + > + printf("\t -- RSS len %u key (hex):", > + rss_conf.rss_key_len); > + for (k =3D 0; k < rss_conf.rss_key_len; k++) > + printf(" %x", rss_conf.rss_key[k]); > + printf("\t -- hf 0x%"PRIx64"\n", > + rss_conf.rss_hf); > + } > + Should this be out of queues for loop?=20 Thanks, Reshma