From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6D6491B3B9 for ; Wed, 12 Dec 2018 15:14:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2018 06:14:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,344,1539673200"; d="scan'208";a="108969555" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga008.fm.intel.com with ESMTP; 12 Dec 2018 06:14:54 -0800 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.233]) by IRSMSX151.ger.corp.intel.com ([169.254.4.32]) with mapi id 14.03.0415.000; Wed, 12 Dec 2018 14:14:54 +0000 From: "Pattan, Reshma" To: "Varghese, Vipin" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "dev@dpdk.org" , "Mcnamara, John" CC: "thomas@monjalon.net" , "Byrne, Stephen1" , "Patel, Amol" Thread-Topic: [PATCH v6 1/9] app/procinfo: add usage for new debug Thread-Index: AQHUisyTMBO53KYfWUm7gMCIGZ2k56V7MfNw Date: Wed, 12 Dec 2018 14:14:53 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3E9BB8@irsmsx110.ger.corp.intel.com> References: <20181122141543.37067-1-vipin.varghese@intel.com> <20181203055000.39012-1-vipin.varghese@intel.com> <20181203055000.39012-2-vipin.varghese@intel.com> In-Reply-To: <20181203055000.39012-2-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWFlY2JkNDktMzQxZi00MjdlLWE3MWUtNDMwMGNmNjk5YzE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUHRQZ2tIUTMxZmJFREtoVmZKeEJGSjVpd25ENkxnZmFHb1wvQlkzMjNzanNoSTViczlnOEhIT0g0TGRYUXBBWTQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/9] app/procinfo: add usage for new debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 14:14:58 -0000 > -----Original Message----- > From: Varghese, Vipin > Sent: Monday, December 3, 2018 5:50 AM > Subject: [PATCH v6 1/9] app/procinfo: add usage for new debug >=20 > @@ -83,7 +87,13 @@ proc_info_usage(const char *prgname) > " --stats-reset: to reset port statistics\n" > " --xstats-reset: to reset port extended statistics\n" > " --collectd-format: to print statistics to STDOUT in expected by > collectd format\n" > - " --host-id STRING: host id used to identify the system process > is running on\n", > + " --host-id STRING: host id used to identify the system process > is running on\n" > + " --show-port to display ports information\n" > + " --show-tm to display traffic manager information for ports\n" > + " --show-crypto to display crypto information\n" > + " --show-ring[=3Dname] to display ring information\n" > + " --show-mempool[=3Dname] to display mempool information\n" > + " --iter-mempool=3Dname to iterate mempool elements\n", > prgname); > } >=20 Style related comment, add ' :' between command token and token message,= similar to host-id and other . Is iter-mempool option, only to iterate only or to display the elements als= o? Then update the help message. Thanks, Reshma