From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A4EFE25B3; Tue, 15 Jan 2019 18:37:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 09:37:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,481,1539673200"; d="scan'208";a="291766962" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga005.jf.intel.com with ESMTP; 15 Jan 2019 09:37:37 -0800 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.16]) by irsmsx105.ger.corp.intel.com ([169.254.7.116]) with mapi id 14.03.0415.000; Tue, 15 Jan 2019 17:37:36 +0000 From: "Pattan, Reshma" To: "Vemula, Hari KumarX" , Chas Williams <3chas3@gmail.com>, "Doherty, Declan" , "dev@dpdk.org" CC: "Parthasarathy, JananeeX M" , "stable@dpdk.org" Thread-Topic: [PATCH] net/bonding: fix create bonded device test failure Thread-Index: AQHUpolDQcBWel2cGE2op/tyyFJZ4qWwoqgg Date: Tue, 15 Jan 2019 17:37:36 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A400D61@irsmsx110.ger.corp.intel.com> References: <1546866064-11929-1-git-send-email-hari.kumarx.vemula@intel.com> In-Reply-To: <1546866064-11929-1-git-send-email-hari.kumarx.vemula@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzQ0NGQ3NzgtNTkxYy00ODE5LWIwOTYtZTI1Y2I4YmQzNjI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOVR2MHhqdTFnZDdpTkRtWGJnMmczcHE0SWFRVm9VVkFkK3BiVndLcXpseDhGSlwvYXVod05GVW5hY0pJNlZPazIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix create bonded device test failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 17:37:40 -0000 > -----Original Message----- > From: Vemula, Hari KumarX > Sent: Monday, January 7, 2019 1:01 PM >=20 >=20 > Signed-off-by: Hari Kumar Vemula > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) >=20 > - memcpy(&dev_info->rx_desc_lim, &internals->rx_desc_lim, > - sizeof(dev_info->rx_desc_lim)); > - memcpy(&dev_info->tx_desc_lim, &internals->tx_desc_lim, > - sizeof(dev_info->tx_desc_lim)); > + dev_info->rx_desc_lim =3D bond_lim; > + dev_info->tx_desc_lim =3D bond_lim; I relooked into this, these values should be filled from salve data like th= e way done for max_nb_rx_queues and max_nb_tx_queues Existing code snippet: if (slave_info.max_rx_queues < max_nb_rx_queues) max_nb_rx_queues =3D slave_info.max_rx_queues; if (slave_info.max_tx_queues < max_nb_tx_queues) max_nb_tx_queues =3D slave_info.max_tx_queues; So, something like below you should add for rx/tx desc limit I guess. if (slave_info.rx_desc_lim.nb_max < max_rx_desc_lim) max_rx_desc_lim =3D slave_info.rx_desc_lim.= nb_max; if (slave_info.tx_desc_lim.nb_max < max_tx_desc_lim) max_tx_desc_lim =3D slave_info.tx_desc_lim.= nb_max; dev_info->rx_desc_lim.nb_max =3D max_rx_desc_lim; dev_info->tx_desc_lim.nb_max =3D max_tx_desc_lim; @Williams/Declan: Does this make sense? Thanks, Reshma