From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E7A8C2965 for ; Fri, 29 Mar 2019 11:52:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2019 03:52:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,284,1549958400"; d="scan'208";a="135872105" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga008.fm.intel.com with ESMTP; 29 Mar 2019 03:52:55 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.102]) by IRSMSX101.ger.corp.intel.com ([169.254.1.230]) with mapi id 14.03.0415.000; Fri, 29 Mar 2019 10:52:54 +0000 From: "Pattan, Reshma" To: "Varghese, Vipin" , "dev@dpdk.org" CC: "Wiles, Keith" , "Mcnamara, John" , "Byrne, Stephen1" , "Tamboli, Amit S" , "Padubidri, Sanjay A" , "Patel, Amol" , "Kovacevic, Marko" Thread-Topic: [PATCH v3] app/pdump: enhance to support multi-core capture Thread-Index: AQHU5Xd9BPo1sDxiaESKXmA9wsg486YiXWhQgAAKKwCAAAQYgA== Date: Fri, 29 Mar 2019 10:52:53 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A432C16@irsmsx110.ger.corp.intel.com> References: <20190328145746.11786-1-vipin.varghese@intel.com> <20190328150406.12051-1-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A432BA2@irsmsx110.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D32780A@BGSMSX101.gar.corp.intel.com> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D32780A@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTVmMjIyMDEtZmI3Yy00YWYyLWI2YzQtYTEwMDk3ZTM5NzliIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibjVIdmRUU1FUT1BmZ1J4XC9mZkFrMk1CMngzaWZFbUFZZWE0eHYweFIxVUJWaWZmYytqczhSK1dpYThKWXJJekwifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] app/pdump: enhance to support multi-core capture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 10:52:57 -0000 > -----Original Message----- > From: Varghese, Vipin > Subject: RE: [PATCH v3] app/pdump: enhance to support multi-core capture > > > > > "'(port=3D | device_id=3D)," > > > "(queue=3D)," > > > "(rx-dev=3D |" > > > @@ -415,6 +416,7 @@ print_pdump_stats(void) > > > for (i =3D 0; i < num_tuples; i++) { > > > printf("##### PDUMP DEBUG STATS #####\n"); > > > pt =3D &pdump_t[i]; > > > + printf(" =3D=3D DPDK interface (%d) =3D=3D\n", i); > > > > Here good to print the portid/deviceid and queue info, instead of > > printing pdump tuple index i? User might not understand that. > I am not sure, why you mention that I am displaying tuple index with I he= re? >=20 What is i here? i is the index used in for loop to iterate through the pdump_tuples array. So printing i doesn't make sense, instead port and queue info are good=20 options to print if you want to have this log. > > Use ### instead of =3D=3D=3D as above. > I can do this, but is there specific reasoning for "####" as it is used t= o represent > main header? to follow consistency with existing display of ###. > > Why not enable the needed number of cores in core mask using eal > > options -l > I think what you are saying is "allow user to pass -l option or -c option= before `-- Yes, and remove existing static -c1 method. So cores that should be enabled will come from eal options, then in --pdump= you=20 have new core param which will be used to launch packet dump function for t= hat pdump tuple. While parsing application pdump core param, you should check this core is e= nabled in coremask of eal. That is the way how other applications do. > `". Then before invoking rte_eal_init replace it. Is this your requiremen= t? >=20 After new suggestion of removing -c1 static approach the above question wil= l not be applicable. > > Ex: > > If you check l3fwd as an example the cores should enabled using -c or > > -l and then they have separate --config l3fwd option in which they > > specify the core on which the packet processing should be run. Please > > check that and similar would be good here too. > I have already explained, pdump application makes static assignment of '-= cx1'. If > you try passing '-c' or '-l' the error check in rte_eal_init will prevent= such > assignment. Now you will remove existing -c1 static assignment and use eal passed -l an= d -c , so it should be fine now. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A1FF9A05D3 for ; Fri, 29 Mar 2019 11:52:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B09E22BD3; Fri, 29 Mar 2019 11:52:58 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E7A8C2965 for ; Fri, 29 Mar 2019 11:52:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2019 03:52:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,284,1549958400"; d="scan'208";a="135872105" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga008.fm.intel.com with ESMTP; 29 Mar 2019 03:52:55 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.102]) by IRSMSX101.ger.corp.intel.com ([169.254.1.230]) with mapi id 14.03.0415.000; Fri, 29 Mar 2019 10:52:54 +0000 From: "Pattan, Reshma" To: "Varghese, Vipin" , "dev@dpdk.org" CC: "Wiles, Keith" , "Mcnamara, John" , "Byrne, Stephen1" , "Tamboli, Amit S" , "Padubidri, Sanjay A" , "Patel, Amol" , "Kovacevic, Marko" Thread-Topic: [PATCH v3] app/pdump: enhance to support multi-core capture Thread-Index: AQHU5Xd9BPo1sDxiaESKXmA9wsg486YiXWhQgAAKKwCAAAQYgA== Date: Fri, 29 Mar 2019 10:52:53 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A432C16@irsmsx110.ger.corp.intel.com> References: <20190328145746.11786-1-vipin.varghese@intel.com> <20190328150406.12051-1-vipin.varghese@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A432BA2@irsmsx110.ger.corp.intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D32780A@BGSMSX101.gar.corp.intel.com> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D32780A@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTVmMjIyMDEtZmI3Yy00YWYyLWI2YzQtYTEwMDk3ZTM5NzliIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibjVIdmRUU1FUT1BmZ1J4XC9mZkFrMk1CMngzaWZFbUFZZWE0eHYweFIxVUJWaWZmYytqczhSK1dpYThKWXJJekwifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] app/pdump: enhance to support multi-core capture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190329105253.s2tolkq1dVKoQQGedJIlkhx0evGm0Crjsx-qRvCwURE@z> > -----Original Message----- > From: Varghese, Vipin > Subject: RE: [PATCH v3] app/pdump: enhance to support multi-core capture > > > > > "'(port=3D | device_id=3D)," > > > "(queue=3D)," > > > "(rx-dev=3D |" > > > @@ -415,6 +416,7 @@ print_pdump_stats(void) > > > for (i =3D 0; i < num_tuples; i++) { > > > printf("##### PDUMP DEBUG STATS #####\n"); > > > pt =3D &pdump_t[i]; > > > + printf(" =3D=3D DPDK interface (%d) =3D=3D\n", i); > > > > Here good to print the portid/deviceid and queue info, instead of > > printing pdump tuple index i? User might not understand that. > I am not sure, why you mention that I am displaying tuple index with I he= re? >=20 What is i here? i is the index used in for loop to iterate through the pdump_tuples array. So printing i doesn't make sense, instead port and queue info are good=20 options to print if you want to have this log. > > Use ### instead of =3D=3D=3D as above. > I can do this, but is there specific reasoning for "####" as it is used t= o represent > main header? to follow consistency with existing display of ###. > > Why not enable the needed number of cores in core mask using eal > > options -l > I think what you are saying is "allow user to pass -l option or -c option= before `-- Yes, and remove existing static -c1 method. So cores that should be enabled will come from eal options, then in --pdump= you=20 have new core param which will be used to launch packet dump function for t= hat pdump tuple. While parsing application pdump core param, you should check this core is e= nabled in coremask of eal. That is the way how other applications do. > `". Then before invoking rte_eal_init replace it. Is this your requiremen= t? >=20 After new suggestion of removing -c1 static approach the above question wil= l not be applicable. > > Ex: > > If you check l3fwd as an example the cores should enabled using -c or > > -l and then they have separate --config l3fwd option in which they > > specify the core on which the packet processing should be run. Please > > check that and similar would be good here too. > I have already explained, pdump application makes static assignment of '-= cx1'. If > you try passing '-c' or '-l' the error check in rte_eal_init will prevent= such > assignment. Now you will remove existing -c1 static assignment and use eal passed -l an= d -c , so it should be fine now.