From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <reshma.pattan@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id E13F12B9C
for <dev@dpdk.org>; Tue, 30 Apr 2019 14:44:35 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
30 Apr 2019 05:44:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,413,1549958400"; d="scan'208";a="146987449"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
by orsmga003.jf.intel.com with ESMTP; 30 Apr 2019 05:44:33 -0700
Received: from irsmsx110.ger.corp.intel.com ([169.254.15.173]) by
IRSMSX152.ger.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0415.000;
Tue, 30 Apr 2019 13:44:33 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Suanming.Mou <mousuanming@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Varghese, Vipin" <vipin.varghese@intel.com>, "Burakov, Anatoly"
<anatoly.burakov@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary
support.
Thread-Index: AQHU/zfbTBGCUCkmL0CVsEuQ/VtGi6ZUoD9w
Date: Tue, 30 Apr 2019 12:44:32 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A44C742@irsmsx110.ger.corp.intel.com>
References: <1556595548-53745-1-git-send-email-mousuanming@huawei.com>
<1556624124-54930-1-git-send-email-mousuanming@huawei.com>
<1556624124-54930-2-git-send-email-mousuanming@huawei.com>
In-Reply-To: <1556624124-54930-2-git-send-email-mousuanming@huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGI1NzU3ZGItZjE4YS00OWM0LWJiOTAtMDdlNjNlMTAyYTU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSEdlNkJMWVk5TUdKSFJxOGZnT1lERVRBcmlFb3g4THpINEx2bGFMNzV3RmJQOTF3MTdsOHNCUDl4WndXR0NzQSJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with
primary support.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Apr 2019 12:44:36 -0000
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Suanming.Mou
> Sent: Tuesday, April 30, 2019 12:35 PM
> To: dev@dpdk.org
> Cc: Varghese, Vipin <vipin.varghese@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Subject: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary
> support.
>=20
> When primary app exits, the residual running pdump will stop the primary =
app to
> restart. Add pdump exits with primary support.
>=20
> Suggested-by: Varghese, Vipin <vipin.varghese@intel.com>
> Suggested-by: Burakov, Anatoly <anatoly.burakov@intel.com>
> Signed-off-by: Suanming.Mou <mousuanming@huawei.com>
You need to run below scripts, and fix the issues reported before sending n=
ext version.
1)
Ex:
export DPDK_CHECKPATCH_PATH=3D/usr/src/kernels/4.18.9-200.fc28.x86_64/scrip=
ts/checkpatch.pl
[DPDK]# ./devtools/checkpatches.sh
### app/pdump: add pudmp exits with primary support.
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate=
line
#62: FILE: app/pdump/main.c:559:
+ * function will take care about that. */
total: 0 errors, 1 warnings, 83 lines checked
0/1 valid patch
2)
[DPDK]# ./devtools/check-git-log.sh
Wrong headline format:
app/pdump: add pudmp exits with primary support.
Need to remove full stop at the end.
Wrong tag:
Suggested-by: Varghese, Vipin <vipin.varghese@intel.com>
Suggested-by: Burakov, Anatoly <anatoly.burakov@intel.com>
Might need to remove ,
> @@ -26,6 +26,7 @@
> #include <rte_ring.h>
> #include <rte_string_fns.h>
> #include <rte_pdump.h>
> +#include <rte_alarm.h>
>=20
Nitpick:
As per the coding guidelines(https://doc.dpdk.org/guides/contributing/codin=
g_style.html)
the order of the headers is below, so you can include rte_alarm.h after <r=
te_eal.h>=20
libc includes (system includes first)
DPDK EAL includes
DPDK misc libraries includes
application-specific includes
> +#define MONITOR_INTERVAL (500 * 1000)
Adding comment on how many ms/us would be helpful.
<snipped>
> + /* Don't worry about it is primary exit case. The alarm cancel
> + * function will take care about that. */
Multiline comments should be like below.
/*
* Multi-line comments look like this. Make them real sentences. Fill
* them so they look like real paragraphs.
*/
Source: https://doc.dpdk.org/guides/contributing/coding_style.html
Thanks,
Reshma
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 6E6EEA0679
for <public@inbox.dpdk.org>; Tue, 30 Apr 2019 14:44:38 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 9FA7F5B36;
Tue, 30 Apr 2019 14:44:37 +0200 (CEST)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id E13F12B9C
for <dev@dpdk.org>; Tue, 30 Apr 2019 14:44:35 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
30 Apr 2019 05:44:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,413,1549958400"; d="scan'208";a="146987449"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
by orsmga003.jf.intel.com with ESMTP; 30 Apr 2019 05:44:33 -0700
Received: from irsmsx110.ger.corp.intel.com ([169.254.15.173]) by
IRSMSX152.ger.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0415.000;
Tue, 30 Apr 2019 13:44:33 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Suanming.Mou <mousuanming@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Varghese, Vipin" <vipin.varghese@intel.com>, "Burakov, Anatoly"
<anatoly.burakov@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary
support.
Thread-Index: AQHU/zfbTBGCUCkmL0CVsEuQ/VtGi6ZUoD9w
Date: Tue, 30 Apr 2019 12:44:32 +0000
Message-ID:
<3AEA2BF9852C6F48A459DA490692831F2A44C742@irsmsx110.ger.corp.intel.com>
References: <1556595548-53745-1-git-send-email-mousuanming@huawei.com>
<1556624124-54930-1-git-send-email-mousuanming@huawei.com>
<1556624124-54930-2-git-send-email-mousuanming@huawei.com>
In-Reply-To: <1556624124-54930-2-git-send-email-mousuanming@huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGI1NzU3ZGItZjE4YS00OWM0LWJiOTAtMDdlNjNlMTAyYTU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSEdlNkJMWVk5TUdKSFJxOGZnT1lERVRBcmlFb3g4THpINEx2bGFMNzV3RmJQOTF3MTdsOHNCUDl4WndXR0NzQSJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with
primary support.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190430124432.ZqG6mNtSTqkG2RW5GUvnZmPWuvmcmgohjG7fb9ZvsZA@z>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Suanming.Mou
> Sent: Tuesday, April 30, 2019 12:35 PM
> To: dev@dpdk.org
> Cc: Varghese, Vipin <vipin.varghese@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Subject: [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary
> support.
>=20
> When primary app exits, the residual running pdump will stop the primary =
app to
> restart. Add pdump exits with primary support.
>=20
> Suggested-by: Varghese, Vipin <vipin.varghese@intel.com>
> Suggested-by: Burakov, Anatoly <anatoly.burakov@intel.com>
> Signed-off-by: Suanming.Mou <mousuanming@huawei.com>
You need to run below scripts, and fix the issues reported before sending n=
ext version.
1)
Ex:
export DPDK_CHECKPATCH_PATH=3D/usr/src/kernels/4.18.9-200.fc28.x86_64/scrip=
ts/checkpatch.pl
[DPDK]# ./devtools/checkpatches.sh
### app/pdump: add pudmp exits with primary support.
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate=
line
#62: FILE: app/pdump/main.c:559:
+ * function will take care about that. */
total: 0 errors, 1 warnings, 83 lines checked
0/1 valid patch
2)
[DPDK]# ./devtools/check-git-log.sh
Wrong headline format:
app/pdump: add pudmp exits with primary support.
Need to remove full stop at the end.
Wrong tag:
Suggested-by: Varghese, Vipin <vipin.varghese@intel.com>
Suggested-by: Burakov, Anatoly <anatoly.burakov@intel.com>
Might need to remove ,
> @@ -26,6 +26,7 @@
> #include <rte_ring.h>
> #include <rte_string_fns.h>
> #include <rte_pdump.h>
> +#include <rte_alarm.h>
>=20
Nitpick:
As per the coding guidelines(https://doc.dpdk.org/guides/contributing/codin=
g_style.html)
the order of the headers is below, so you can include rte_alarm.h after <r=
te_eal.h>=20
libc includes (system includes first)
DPDK EAL includes
DPDK misc libraries includes
application-specific includes
> +#define MONITOR_INTERVAL (500 * 1000)
Adding comment on how many ms/us would be helpful.
<snipped>
> + /* Don't worry about it is primary exit case. The alarm cancel
> + * function will take care about that. */
Multiline comments should be like below.
/*
* Multi-line comments look like this. Make them real sentences. Fill
* them so they look like real paragraphs.
*/
Source: https://doc.dpdk.org/guides/contributing/coding_style.html
Thanks,
Reshma