From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 9975329D2 for ; Thu, 2 May 2019 11:54:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 02:54:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="169862368" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga001.fm.intel.com with ESMTP; 02 May 2019 02:54:30 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.173]) by IRSMSX153.ger.corp.intel.com ([169.254.9.61]) with mapi id 14.03.0415.000; Thu, 2 May 2019 10:54:30 +0100 From: "Pattan, Reshma" To: Suanming.Mou , "dev@dpdk.org" CC: "Varghese, Vipin" , "Burakov, Anatoly" Thread-Topic: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support Thread-Index: AQHVAJbzoYrOKuF8dk6jqqTJMHs9T6ZXlkgw Date: Thu, 2 May 2019 09:54:29 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A44CFAE@irsmsx110.ger.corp.intel.com> References: <1556624124-54930-2-git-send-email-mousuanming@huawei.com> <1556774432-59147-1-git-send-email-mousuanming@huawei.com> In-Reply-To: <1556774432-59147-1-git-send-email-mousuanming@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTM4MzU4OTgtYzU0Yy00ZDA5LTliYmYtOTc5YWVkODZhMGI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQmgyNVptZUxWMDBpNVhLMXV6VXEwd0xwQWxHdGtKV1FcL1NwSFRHbEduR0lCWnZMQkRlT3M0dWxPQmx0ZWpFNWsifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 09:54:33 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Suanming.Mou > static void > +monitor_primary(void *arg __rte_unused) { > + if (quit_signal) > + return; > + > + if (rte_eal_primary_proc_alive(NULL)) > + rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary, > NULL); > + else > + quit_signal =3D 1; > +} > + Adding the log message saying primary existing so, secondary.. would be hel= pful here. I am ok to have it as default behaviour. =20 As Vipin mentioned, can you also update the document doc/guides/tools/pdump= .rst Thanks, Reshma From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C75DEA0AC5 for ; Thu, 2 May 2019 11:54:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26AB12BF2; Thu, 2 May 2019 11:54:34 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 9975329D2 for ; Thu, 2 May 2019 11:54:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 02:54:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="169862368" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga001.fm.intel.com with ESMTP; 02 May 2019 02:54:30 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.173]) by IRSMSX153.ger.corp.intel.com ([169.254.9.61]) with mapi id 14.03.0415.000; Thu, 2 May 2019 10:54:30 +0100 From: "Pattan, Reshma" To: Suanming.Mou , "dev@dpdk.org" CC: "Varghese, Vipin" , "Burakov, Anatoly" Thread-Topic: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support Thread-Index: AQHVAJbzoYrOKuF8dk6jqqTJMHs9T6ZXlkgw Date: Thu, 2 May 2019 09:54:29 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A44CFAE@irsmsx110.ger.corp.intel.com> References: <1556624124-54930-2-git-send-email-mousuanming@huawei.com> <1556774432-59147-1-git-send-email-mousuanming@huawei.com> In-Reply-To: <1556774432-59147-1-git-send-email-mousuanming@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTM4MzU4OTgtYzU0Yy00ZDA5LTliYmYtOTc5YWVkODZhMGI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQmgyNVptZUxWMDBpNVhLMXV6VXEwd0xwQWxHdGtKV1FcL1NwSFRHbEduR0lCWnZMQkRlT3M0dWxPQmx0ZWpFNWsifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502095429.ryAbTQB243YnkpyfaJLaXhVs4YvJreqVJyqz3kDgc88@z> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Suanming.Mou > static void > +monitor_primary(void *arg __rte_unused) { > + if (quit_signal) > + return; > + > + if (rte_eal_primary_proc_alive(NULL)) > + rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary, > NULL); > + else > + quit_signal =3D 1; > +} > + Adding the log message saying primary existing so, secondary.. would be hel= pful here. I am ok to have it as default behaviour. =20 As Vipin mentioned, can you also update the document doc/guides/tools/pdump= .rst Thanks, Reshma