From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Govindarajan, LavanyaX" <lavanyax.govindarajan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/test: add unit test cases for mbuf library APIs
Date: Fri, 31 May 2019 10:45:39 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A463102@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <1555332015-31506-1-git-send-email-lavanyax.govindarajan@intel.com>
> -----Original Message-----
> From: Govindarajan, LavanyaX
> Sent: Monday, April 15, 2019 1:40 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; olivier.matz@6wind.com;
> Richardson, Bruce <bruce.richardson@intel.com>; Govindarajan, LavanyaX
> <lavanyax.govindarajan@intel.com>
> Subject: [PATCH] app/test: add unit test cases for mbuf library APIs
>
<snip>
> __func__);
> + if (rte_pktmbuf_data_len(pkt_seg) !=
> + MBUF_TEST_SEG_SIZE)
> + GOTO_FAIL("%s: Bad data length\n",
> __func__);
> + memset(data, (seg + nb_pkt + 0xaa) % 0x0ff,
> + MBUF_TEST_SEG_SIZE);
> +
Also nb_pkt+0xaa is common for all segments, so doing the addition for each segments waste of cycles, so move to addition out for segments for loop.
Other than that, please keep reviewed-by in next versions.
Reviewed-By: Reshma Pattan <reshma.pattan@intel.com>
Thanks,
Reshma
next prev parent reply other threads:[~2019-05-31 10:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 12:40 Lavanya Govindarajan
2019-04-15 12:40 ` Lavanya Govindarajan
2019-05-31 10:45 ` Pattan, Reshma [this message]
2019-06-03 8:39 ` Olivier Matz
2019-07-22 13:32 ` Govindarajan, LavanyaX
2019-08-13 10:26 ` Govindarajan, LavanyaX
2019-08-22 11:21 ` Govindarajan, LavanyaX
2019-07-22 13:42 ` [dpdk-dev] [PATCH v2 0/2] add unit test cases for mbuf library Lavanya Govindarajan
2019-07-22 13:42 ` [dpdk-dev] [PATCH v2 1/2] app/test: add unit test cases for mbuf library APIs Lavanya Govindarajan
2019-07-22 13:42 ` [dpdk-dev] [PATCH v2 2/2] app/test: add unit test cases to mbuf Lavanya Govindarajan
2019-07-23 12:14 ` [dpdk-dev] [PATCH v3 0/2] add unit test cases for mbuf library Lavanya Govindarajan
2019-07-23 12:14 ` [dpdk-dev] [PATCH v3 1/2] app/test: add unit test cases for mbuf library APIs Lavanya Govindarajan
2019-08-08 13:34 ` [dpdk-dev] [PATCH v4 0/2] add unit test cases for mbuf library Lavanya Govindarajan
2019-08-08 13:34 ` [dpdk-dev] [PATCH v4 1/2] app/test: add unit test cases for mbuf library APIs Lavanya Govindarajan
2019-08-26 8:47 ` Olivier Matz
2019-08-30 14:13 ` [dpdk-dev] [PATCH v5 0/2] add unit test cases for mbuf library Lavanya Govindarajan
2019-10-24 7:54 ` David Marchand
2019-08-30 14:13 ` [dpdk-dev] [PATCH v5 1/2] app/test: add unit test cases for mbuf library APIs Lavanya Govindarajan
2019-08-30 14:13 ` [dpdk-dev] [PATCH v5 2/2] app/test: add unit test for mbuf flag names Lavanya Govindarajan
2019-08-08 13:34 ` [dpdk-dev] [PATCH v4 2/2] app/test: add unit test cases to mbuf Lavanya Govindarajan
2019-08-26 9:09 ` Olivier Matz
2019-07-23 12:14 ` [dpdk-dev] [PATCH v3 " Lavanya Govindarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A463102@irsmsx110.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=lavanyax.govindarajan@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).