From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E865AA045E for ; Fri, 31 May 2019 12:45:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B35BA1B945; Fri, 31 May 2019 12:45:44 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 589D4375B for ; Fri, 31 May 2019 12:45:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2019 03:45:42 -0700 X-ExtLoop1: 1 Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga006.jf.intel.com with ESMTP; 31 May 2019 03:45:41 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.227]) by IRSMSX153.ger.corp.intel.com ([169.254.9.129]) with mapi id 14.03.0415.000; Fri, 31 May 2019 11:45:40 +0100 From: "Pattan, Reshma" To: "Govindarajan, LavanyaX" , "dev@dpdk.org" CC: "olivier.matz@6wind.com" , "Richardson, Bruce" Thread-Topic: [PATCH] app/test: add unit test cases for mbuf library APIs Thread-Index: AQHU84iKuYBPvOmJTU2z33sG36K4g6aFUzmg Date: Fri, 31 May 2019 10:45:39 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A463102@irsmsx110.ger.corp.intel.com> References: <1555332015-31506-1-git-send-email-lavanyax.govindarajan@intel.com> In-Reply-To: <1555332015-31506-1-git-send-email-lavanyax.govindarajan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTE2NzFkYzMtM2I1YS00YmFmLTkwOTItYjE3ZjkwN2E0MTM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYjhseVBtaU11V01rVG9Jd3lmZTBUSnNiNHpoYjBMRFhLWEJlZXF0dnhER1VUM0szNzRWdWtZNVFmbFNuTDBrKyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test: add unit test cases for mbuf library APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Govindarajan, LavanyaX > Sent: Monday, April 15, 2019 1:40 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; olivier.matz@6wind.com; > Richardson, Bruce ; Govindarajan, LavanyaX > > Subject: [PATCH] app/test: add unit test cases for mbuf library APIs >=20 > __func__); > + if (rte_pktmbuf_data_len(pkt_seg) !=3D > + MBUF_TEST_SEG_SIZE) > + GOTO_FAIL("%s: Bad data length\n", > __func__); > + memset(data, (seg + nb_pkt + 0xaa) % 0x0ff, > + MBUF_TEST_SEG_SIZE); > + Also nb_pkt+0xaa is common for all segments, so doing the addition for eac= h segments waste of cycles, so move to addition out for segments for loop. Other than that, please keep reviewed-by in next versions. Reviewed-By: Reshma Pattan Thanks, Reshma