From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92692A046B for ; Thu, 27 Jun 2019 12:59:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D97A21E2F; Thu, 27 Jun 2019 12:59:17 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 0DAF91E25; Thu, 27 Jun 2019 12:59:15 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 03:59:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,423,1557212400"; d="scan'208";a="313756580" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga004.jf.intel.com with ESMTP; 27 Jun 2019 03:59:13 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.217]) by IRSMSX103.ger.corp.intel.com ([169.254.3.140]) with mapi id 14.03.0439.000; Thu, 27 Jun 2019 11:59:12 +0100 From: "Pattan, Reshma" To: Harman Kalra , "Burakov, Anatoly" , "Kovacevic, Marko" , "Mcnamara, John" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] metrics: new API to deinitialise metrics library Thread-Index: AQHU0Ba58h7v8+nvZkCL5A9JvA5LHKawCexA Date: Thu, 27 Jun 2019 10:59:12 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A4881C5@irsmsx110.ger.corp.intel.com> References: <1551264691-26353-1-git-send-email-hkalra@marvell.com> <1551434828-3518-1-git-send-email-hkalra@marvell.com> In-Reply-To: <1551434828-3518-1-git-send-email-hkalra@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDZkZGI2YjMtNzg3My00NGUzLTljNTktZDY1ODk1ZWQwZTRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNzRuNHo0MzRNdVp2QmNCb3pWb00xcTIyMDhuOUgwaklUQlM4c3lhaXUzZHo5ZjRhazVxYjlCd0djdGl1MDVrMiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] metrics: new API to deinitialise metrics library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harman Kalra > Sent: Friday, March 1, 2019 10:08 AM > To: Horton, Remy ; Burakov, Anatoly > ; Kovacevic, Marko > ; Mcnamara, John > > Cc: dev@dpdk.org; stable@dpdk.org; Harman Kalra > Subject: [dpdk-dev] [PATCH v2 1/2] metrics: new API to deinitialise metri= cs > library >=20 > Once the library usage is over, it must be deinitialized which will free = the > shared memory reserved during initialization. >=20 > Fixes: observed an issue while running 'metrics_autotest' > continuously without quiting. For the first run 'metrics_autotest' > passes all test cases but second run onwards first test case fails becaus= e > metrics library is already initialized during first run. > Cc: stable@dpdk.org >=20 > Signed-off-by: Harman Kalra > --- > v2: > * Adding stable@dpdk.org into cc as this patch falls between bug fix and > new feature. >=20 > doc/guides/prog_guide/metrics_lib.rst | 14 ++++++++++++++ > lib/librte_metrics/rte_metrics.c | 20 ++++++++++++++++++++ > lib/librte_metrics/rte_metrics.h | 17 +++++++++++++++++ > lib/librte_metrics/rte_metrics_version.map | 6 ++++++ > 4 files changed, 57 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/metrics_lib.rst > b/doc/guides/prog_guide/metrics_lib.rst > index e68e4e743..08e107df3 100644 > --- a/doc/guides/prog_guide/metrics_lib.rst > +++ b/doc/guides/prog_guide/metrics_lib.rst > @@ -154,6 +154,20 @@ print out all metrics for a given port: > } >=20 >=20 > +Deinitialising the library > +------------------------ 1) The underline should be same length as heading. Below is the error from "ma= ke doc-guides-html" sphinx processing guides-html... metrics_lib.rst:158: WARNING: Title underline too short. Deinitialising the library ------------------------ metrics_lib.rst:158: WARNING: Title underline too short. 2) Need to fix below ./devtools/check-git-log.sh Wrong tag: Fixes: observed an issue while running 'metrics_autotest' Wrong 'Fixes' reference: Fixes: observed an issue while running 'metrics_autotest' If you want to add Fixes line it should be of below form Fixes: ("commit heading") Ex: Fixes: d7a0da3c0043 ("mempool/octeontx2: add fast path mempool ops") Otherwise,=20 Tested-by : Reshma Pattan Reviewed-by: Reshma Pattan Acked-by: Reshma Pattan Please keep these tags for next versions, otherwise it can easily miss fro= m being applied. Thanks, Reshma