From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7E1C38D85 for ; Tue, 10 Nov 2015 14:46:34 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 10 Nov 2015 05:46:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,270,1444719600"; d="scan'208";a="832890076" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga001.fm.intel.com with ESMTP; 10 Nov 2015 05:46:28 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.96]) by irsmsx105.ger.corp.intel.com ([169.254.7.203]) with mapi id 14.03.0248.002; Tue, 10 Nov 2015 13:46:27 +0000 From: "Pattan, Reshma" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] l3fwd: fix lookup burst size for ipv6 Thread-Index: AQHRFnRG4CZvBJS1b0uFzdFrqRwmip6VTvOg Date: Tue, 10 Nov 2015 13:46:26 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831FF7EDF1@IRSMSX109.ger.corp.intel.com> References: <1446580605-131889-1-git-send-email-pablo.de.lara.guarch@intel.com> <1446581628-133217-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1446581628-133217-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] l3fwd: fix lookup burst size for ipv6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 13:46:35 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, November 3, 2015 8:14 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] l3fwd: fix lookup burst size for ipv6 >=20 > Lookup burst size was changed for exact match from 4 to 8, for both ipv4 = and > ipv6, but actually only > 4 keys were being looked up for ipv6, instead of 8, causing random > segmentation faults. >=20 > Fixes: 80fcb4d4 ("examples/l3fwd: increase lookup burst size to 8") >=20 > Signed-off-by: Pablo de Lara > --- > Changes in v2: > - Include update in release notes >=20 > doc/guides/rel_notes/release_2_2.rst | 4 ++++ > examples/l3fwd/main.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/guides/rel_notes/release_2_2.rst > b/doc/guides/rel_notes/release_2_2.rst > index b39a78a..0172354 100644 > --- a/doc/guides/rel_notes/release_2_2.rst > +++ b/doc/guides/rel_notes/release_2_2.rst > @@ -143,6 +143,10 @@ Libraries > Examples > ~~~~~~~~ >=20 > +* **l3fwd: fix lookup burst size for ipv6.** > + > + Fixed issue where app crashes if ipv6 is used, due to a wrong lookup > + burst size. >=20 > Other > ~~~~~ > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index > 1f3e5c6..74703b0 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -1005,7 +1005,7 @@ simple_ipv6_fwd_8pkts(struct rte_mbuf *m[8], > uint8_t portid, struct lcore_conf * > const void *key_array[8] =3D {&key[0], &key[1], &key[2], &key[3], > &key[4], &key[5], &key[6], &key[7]}; >=20 > - rte_hash_lookup_multi(qconf->ipv6_lookup_struct, &key_array[0], 4, > ret); > + rte_hash_lookup_multi(qconf->ipv6_lookup_struct, &key_array[0], 8, > +ret); > dst_port[0] =3D (uint8_t) ((ret[0] < 0) ? portid:ipv6_l3fwd_out_if[ret[= 0]]); > dst_port[1] =3D (uint8_t) ((ret[1] < 0) ? portid:ipv6_l3fwd_out_if[ret[= 1]]); > dst_port[2] =3D (uint8_t) ((ret[2] < 0) ? portid:ipv6_l3fwd_out_if[ret[= 2]]); > -- > 2.4.3 Acked-by: Reshma Pattan