From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 92CFB8DED for ; Thu, 24 Dec 2015 18:40:21 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 24 Dec 2015 09:40:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,474,1444719600"; d="scan'208";a="623306562" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 24 Dec 2015 09:40:19 -0800 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.96]) by IRSMSX102.ger.corp.intel.com ([169.254.2.251]) with mapi id 14.03.0248.002; Thu, 24 Dec 2015 17:40:19 +0000 From: "Pattan, Reshma" To: "Qiu, Michael" , "Doherty, Declan" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 1/3] librte_ether: remove RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET Thread-Index: AQHRPiFdDMxNJ795XEOhuSdXeheZRp7aYUQA Date: Thu, 24 Dec 2015 17:40:17 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831FF8E2AD@IRSMSX109.ger.corp.intel.com> References: <1450873172-21932-1-git-send-email-reshma.pattan@intel.com> <533710CFB86FA344BFBF2D6802E6028622F0018D@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E6028622F0018D@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] librte_ether: remove RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2015 17:40:22 -0000 > -----Original Message----- > From: Qiu, Michael > On 12/23/2015 8:19 PM, Reshma Pattan wrote: > > Macros RTE_PROC_PRIMARY_OR_ERR_RET and > RTE_PROC_PRIMARY_OR_RET are > > blocking the secondary process from using the APIs. > > API access should be given to both secondary and primary. >=20 > Just as the log says, is it safe to do so? Hi, Some parts of the code still need these macros, which I am not sure yet. Bu= t as and when we identify those we have to add the macros to the needed pla= ces.=20 But it is safe to remove from start of function to allow secondary process = to do device configuration and queue setups for vdev.=20 Please let me know if you know any of such cases where these macros should = be added. Thanks, Reshma =09