From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 849B8A04AB; Thu, 7 Nov 2019 04:00:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F1A91DFEC; Thu, 7 Nov 2019 04:00:28 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DF0651DFEA for ; Thu, 7 Nov 2019 04:00:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 19:00:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="403951185" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 06 Nov 2019 19:00:25 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 19:00:25 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 19:00:25 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.63]) with mapi id 14.03.0439.000; Thu, 7 Nov 2019 11:00:23 +0800 From: "Di, ChenxuX" To: "Ye, Xiaolong" CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Yang, Qiming" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix device hotplug remove Thread-Index: AQHVlGbRa+55F7LhvkKe63If1TDjkKd+fVCAgACHk+A= Date: Thu, 7 Nov 2019 03:00:22 +0000 Message-ID: <3B926E44943CB04AA3A39AC16328CE39B6B1F8@SHSMSX101.ccr.corp.intel.com> References: <20191024010310.35882-1-chenxux.di@intel.com> <20191106050847.82673-1-chenxux.di@intel.com> <20191107025029.GB68021@intel.com> In-Reply-To: <20191107025029.GB68021@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix device hotplug remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Xiaolong About pf and vf for fm10k, e1000, igb, ixgbe, ice, i40e; only i40e pf and i= xgbe vf use=20 Rte_eth_dev_destory() in their remove function, others have already use the= generic remove function. I have send another patch about ixgbe because they fix different commits. Thanks Di Chenxu=20 > -----Original Message----- > From: Ye, Xiaolong > Sent: Thursday, November 7, 2019 10:50 AM > To: Di, ChenxuX > Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > ; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix device hotplug remove >=20 > On 11/06, Di ChenxuX wrote: > >testpmd will occur infinite loops when device hotplug remove. > >We can fix the issue by using the pci generic remove function > > > >Fixes: ac89d46096d5 ("net/i40e: release port upon close") > > > >Signed-off-by: Di ChenxuX > > > >v2: > >change the code in driver. > >--- > > drivers/net/i40e/i40e_ethdev.c | 12 +----------- > > 1 file changed, 1 insertion(+), 11 deletions(-) > > > >diff --git a/drivers/net/i40e/i40e_ethdev.c > >b/drivers/net/i40e/i40e_ethdev.c index 77a46832c..64842867d 100644 > >--- a/drivers/net/i40e/i40e_ethdev.c > >+++ b/drivers/net/i40e/i40e_ethdev.c > >@@ -694,17 +694,7 @@ eth_i40e_pci_probe(struct rte_pci_driver *pci_drv > >__rte_unused, > > > > static int eth_i40e_pci_remove(struct rte_pci_device *pci_dev) { > >- struct rte_eth_dev *ethdev; > >- > >- ethdev =3D rte_eth_dev_allocated(pci_dev->device.name); > >- if (!ethdev) > >- return -ENODEV; > >- > >- > >- if (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) > >- return rte_eth_dev_destroy(ethdev, > i40e_vf_representor_uninit); > >- else > >- return rte_eth_dev_destroy(ethdev, eth_i40e_dev_uninit); > >+ return rte_eth_dev_pci_generic_remove(pci_dev, eth_i40e_dev_uninit); >=20 > What about i40e_vf_representor_uninit, you also need to take it into > consideration. >=20 > And you should also call rte_eth_dev_release_port in remove ops in case u= ser > detach a port directly without closing it first. >=20 > This comment also applies your ixgbe fix. >=20 >=20 > Thanks, > Xiaolong >=20 >=20 > > } > > > > static struct rte_pci_driver rte_i40e_pmd =3D { > >-- > >2.17.1 > >