From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <amr.mokhtar@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 85AD63DC
 for <dev@dpdk.org>; Fri,  1 Sep 2017 23:35:10 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga105.jf.intel.com with ESMTP; 01 Sep 2017 14:35:09 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,459,1498546800"; d="scan'208";a="1010150120"
Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3])
 by orsmga003.jf.intel.com with ESMTP; 01 Sep 2017 14:35:08 -0700
Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by
 IRSMSX108.ger.corp.intel.com ([169.254.11.167]) with mapi id 14.03.0319.002;
 Fri, 1 Sep 2017 22:35:07 +0100
From: "Mokhtar, Amr" <amr.mokhtar@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [RFC] Wireless Base Band Device (bbdev)
Thread-Index: AQHTHaidyFtCgYsXxUqHDbe8mN+d6KKgbrmAgAAfj5A=
Date: Fri, 1 Sep 2017 21:35:07 +0000
Message-ID: <3D3765A8CDB52A4C8B410430AA19CB236EC2944E@IRSMSX104.ger.corp.intel.com>
References: <1503668796-65832-1-git-send-email-amr.mokhtar@intel.com>
 <20170901130339.76dc0457@xeon-e3>
In-Reply-To: <20170901130339.76dc0457@xeon-e3>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTE5NGJkY2QtOGM5Yi00ZjU4LWEyNmMtYTg3YTFhZWIyMWNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjViZHdWdVFjQlZma0FpQXR2RDZJVHdFbzVhSEFtaGlBSktURzlkWVwvdW9VPSJ9
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [RFC] Wireless Base Band Device (bbdev)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Sep 2017 21:35:10 -0000

Thanks Stephen.
Agree. Will remove dependency on PCI for now. And num_queues should have be=
en declared as uint16_t.

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday 1 September 2017 21:04
> To: Mokhtar, Amr <amr.mokhtar@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC] Wireless Base Band Device (bbdev)
>=20
>=20
> > +/* Forward declaration */
> > +struct rte_pci_device;
> > +
> > +/** Device information structure used by an application to discover a
> > +devices
> > + * capabilities and current configuration  */ struct rte_bbdev_info {
> > +	int socket_id;  /**< NUMA socket that device is on */
> > +	const char *dev_name;  /**< Unique device name */
> > +	const struct rte_pci_device *pci_dev;  /**< PCI information */
> > +	unsigned int num_queues;  /**< Number of queues currently configured
> */
> > +	struct rte_bbdev_conf conf;  /**< Current device configuration */
> > +	bool started;  /**< Set if device is currently started */
> > +	struct rte_bbdev_driver_info drv;  /**< Info from device driver */
> > +};
>=20
> Please don't build in dependency on PCI from the beginning.
> Number of queues can be uint16_t ?