From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2592D5F13; Wed, 24 Oct 2018 10:51:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 01:51:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,419,1534834800"; d="scan'208";a="100222560" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 24 Oct 2018 01:50:59 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Oct 2018 01:50:59 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Oct 2018 01:50:58 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.199]) with mapi id 14.03.0415.000; Wed, 24 Oct 2018 16:50:57 +0800 From: "Wang, Dong1" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" , "Yigit, Ferruh" , Thomas Monjalon Thread-Topic: [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port Thread-Index: AQHUZfA2EUWHe62vBUSHrZVeqcw2+qUjFJzwgAr+NtCAAAt4IA== Date: Wed, 24 Oct 2018 08:50:56 +0000 Message-ID: <3E2E5017C928014B90FD7864A64F0B5514F64677@SHSMSX103.ccr.corp.intel.com> References: <1539762086-15569-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTk4NzVlMDMtMGJjYS00NWY0LTliODUtZTNmYzE1NTlhZGZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQVZTQnQrTHU5UE5NOTA1aFNFT2VmZjk4cnFMdWJ6Wkk5c3Q4bHBNMUNkZWJGa1V1RForSHF6UmJwcHVmZjZsVCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 24 Oct 2018 11:11:56 +0200 Subject: Re: [dpdk-dev] [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 08:51:01 -0000 Tested it with 82599 PF. Acked-by: Wang Dong -----Original Message----- From: Zhao1, Wei=20 Sent: Wednesday, October 24, 2018 16:11 To: Zhao1, Wei ; dev@dpdk.org Cc: stable@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh ; Wang, Dong1 ; Thomas Monjalon <= thomas@monjalon.net> Subject: RE: [PATCH] examples/ipv4_multicast: enable multicast promiscuous = for all port Add Wang Dong in the mailing list, he has test this patch. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Wednesday, October 17, 2018 4:09 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh=20 > > Subject: Re: [dpdk-dev] [PATCH] examples/ipv4_multicast: enable=20 > multicast promiscuous for all port >=20 > By the way, I think the maintainer's opinion is important for this=20 > change, but there is no maintainer name for this example in file MAINTAIN= ERS! >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Wednesday, October 17, 2018 3:41 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Zhang, Qi Z ; Yigit,=20 > > Ferruh ; Zhao1, Wei > > Subject: [PATCH] examples/ipv4_multicast: enable multicast=20 > > promiscuous for all port > > > > This example has not been enable for receiving multicast packet, so=20 > > it will drop multicast packet. Users must send packet with ether MAC=20 > > destination address the same as pf port MAC address, in order to=20 > > forward packet successfully, but this is an example for forwarding > > ipv4 multicastpacket. So calling function > > rte_eth_promiscuous_enable() or rte_eth_allmulticast_enable() can=20 > > enable promiscuous mode of all multicast packet. And aslo, DPDK has=20 > > rte API function of rte_eth_dev_set_mc_addr_list() for setting=20 > > specific multicast filter table for specific multicast IP address,=20 > > but this example do not support this configuration, so it need to be=20 > > enable multicast promiscuous mode instead. > > > > Signed-off-by: Wei Zhao > > --- > > examples/ipv4_multicast/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/ipv4_multicast/main.c=20 > > b/examples/ipv4_multicast/main.c index 6530d48..4073a49 100644 > > --- a/examples/ipv4_multicast/main.c > > +++ b/examples/ipv4_multicast/main.c > > @@ -773,7 +773,7 @@ main(int argc, char **argv) > > qconf->tx_queue_id[portid] =3D queueid; > > queueid++; > > } > > - > > + rte_eth_allmulticast_enable(portid); > > /* Start device */ > > ret =3D rte_eth_dev_start(portid); > > if (ret < 0) > > -- > > 2.7.5