From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C987A5F16; Wed, 14 Nov 2018 12:33:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2018 03:33:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,232,1539673200"; d="scan'208";a="89204747" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 14 Nov 2018 03:33:48 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 14 Nov 2018 03:33:48 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 14 Nov 2018 03:33:47 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.214]) with mapi id 14.03.0415.000; Wed, 14 Nov 2018 19:33:46 +0800 From: "Wang, Dong1" To: "Ananyev, Konstantin" , "Lipiec, Herakliusz" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "Burakov, Anatoly" , "stable@dpdk.org" Thread-Topic: [PATCH v2] example/ipv4_multicast: fix app hanging when using clone Thread-Index: AQHUe0b5pKJEC1/DAEOLWHRQIh7gp6VNEc6AgAITVsA= Date: Wed, 14 Nov 2018 11:33:45 +0000 Message-ID: <3E2E5017C928014B90FD7864A64F0B5514F7505D@SHSMSX103.ccr.corp.intel.com> References: <20181112204650.7175-1-herakliusz.lipiec@intel.com> <20181113114929.9269-1-herakliusz.lipiec@intel.com> <2601191342CEEE43887BDE71AB977258010CE49D0D@IRSMSX106.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258010CE49D0D@IRSMSX106.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2JiODFjODEtNzljOS00NTBjLWIyZGQtNTg2NDBkMzhkMWRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieko0T2lBYzM4UklSQjNSdDhsMWh6UGdFdWV3UTlma0w2T3JrVFJjbXB4KzNCdmNDbVNQRFwvRG1sTTNcL2V4R1ZjIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 11:33:50 -0000 Acked-by: Wang Dong -----Original Message----- From: Ananyev, Konstantin=20 Sent: Tuesday, November 13, 2018 19:52 To: Lipiec, Herakliusz ; dev@dpdk.org Cc: Wang, Dong1 ; thomas@monjalon.net; Burakov, Anato= ly ; stable@dpdk.org Subject: RE: [PATCH v2] example/ipv4_multicast: fix app hanging when using = clone > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Tuesday, November 13, 2018 11:49 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Wang, Dong1=20 > ; thomas@monjalon.net; Burakov, Anatoly=20 > ; Lipiec, Herakliusz=20 > ; stable@dpdk.org > Subject: [PATCH v2] example/ipv4_multicast: fix app hanging when using=20 > clone >=20 > The ipv4_multicast sample application was dropping packets when using=20 > mbuf clone. When creating an L2 header and copying metadata from the=20 > source packet, the ol_flags were also copied along with all the other=20 > metadata. Because the cloned packet had IND_ATTACHED_MBUF flag set in=20 > its ol_flags, this caused the packets to never be freed when using=20 > rte_pktmbuf_free. > Since copying ol_flags from the cloned packet is not necessary in the=20 > first place, just don't do it. >=20 > Fixes: af75078fece3 ("first public release") > CC: stable@dpdk.org >=20 > Reported-by: Wang Dong > Signed-off-by: Herakliusz Lipiec > --- Acked-by: Konstantin Ananyev