From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8A100B789 for ; Fri, 20 Feb 2015 19:32:07 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 20 Feb 2015 10:32:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,616,1418112000"; d="scan'208";a="457335339" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by FMSMGA003.fm.intel.com with ESMTP; 20 Feb 2015 10:16:52 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX151.ger.corp.intel.com ([169.254.4.7]) with mapi id 14.03.0195.001; Fri, 20 Feb 2015 18:32:04 +0000 From: "Dumitrescu, Cristian" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read Thread-Index: AQHQQQsGJzFcjembK0CI5da80PrjtZzo8ijwgAACqoCAEP2yYA== Date: Fri, 20 Feb 2015 18:32:03 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263231B296@IRSMSX108.ger.corp.intel.com> References: <1423116841-19799-4-git-send-email-stephen@networkplumber.org> <3EB4FA525960D640B5BDFFD6A3D89126323097BA@IRSMSX108.ger.corp.intel.com> <20150209145509.1b7bea9b@uryu.home.lan> In-Reply-To: <20150209145509.1b7bea9b@uryu.home.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 18:32:08 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, February 9, 2015 10:55 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics = when > read > = > On Mon, 9 Feb 2015 22:48:36 +0000 > "Dumitrescu, Cristian" wrote: > = > > Hi Stephen, > > > > What is the reason not to clear statistics on read? Do you have a use-c= ase / > justification for it? > > > > (BTW, I see you added the reset functions, but was it also your intenti= on to > remove the memset to 0 from the stats read functions? :) ) > > > > Regards, > > Cristian > = > Read and clear is a non-standard model. Interface statistics are not > read/clear. > We have lots of scripts that read statistics. Users don't like it if when > stastics disappear. Stephen, I suggest adding a new build-time configuration option for the lib= rte_sched library in config/common_* files: CONFIG_RTE_SCHED_STATS_CLEAR_ON= _READ. - When set to YES, we clear the stats counters on read. When set to NO, we = do not clear stats counters on read; - The default value for this configuration option should be YES, in order t= o preserve the backward compatibility with the current behavior; - The stats reset functions introduced by this patch should always be enabl= ed/compiled into the code, regardless of whether this new option is set to = YES or NO. What do you think? Regards, Cristian -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.