From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A20D1B7B1 for ; Fri, 20 Feb 2015 22:29:00 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 20 Feb 2015 13:28:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,617,1418112000"; d="scan'208";a="688559435" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga002.jf.intel.com with ESMTP; 20 Feb 2015 13:28:57 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX106.ger.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0195.001; Fri, 20 Feb 2015 21:28:56 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read Thread-Index: AQHQTVB1ifGWiPks+kSBjrRmhoXOO5z6C9Dw Date: Fri, 20 Feb 2015 21:28:55 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263231B3B2@IRSMSX108.ger.corp.intel.com> References: <1423116841-19799-4-git-send-email-stephen@networkplumber.org> <20150220115256.7557e716@urahara> <3EB4FA525960D640B5BDFFD6A3D891263231B33C@IRSMSX108.ger.corp.intel.com> <2937997.VuavGYZbL6@xps13> In-Reply-To: <2937997.VuavGYZbL6@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 21:29:01 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, February 20, 2015 9:01 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics = when > read > = > 2015-02-20 20:23, Dumitrescu, Cristian: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > On Fri, 20 Feb 2015 18:32:03 +0000 > > > "Dumitrescu, Cristian" wrote: > > > > > > > Stephen, I suggest adding a new build-time configuration option for= the > > > > librte_sched library in config/common_* files: > > > > CONFIG_RTE_SCHED_STATS_CLEAR_ON_READ. > > > > > > Build time config options do not work for distributions. > > > > Why? > > > > This does not affect the API, as the new API functions are always compi= led > > in, and the prototypes are not changed, and no data structures are > affected. > = > Behaviour is an important part of the API. Think comments as part of the = API. Makes sense. > = > > This only changes the behavior of certain functions, so that user can > > select which mode it needs. > = > When user doesn't or cannot rebuild, he has no choice. > = > > It also preserves backward compatibility. > > > > We have so many compilation options in config file, why is this one > different? > = > We must remove and avoid build-time options. > The only ones which might be acceptable are the ones which allow more > performance by disabling some features. Agree. Stephen, how about a run-time solution (I agree it would be much better, wh= y did I not consider this in the first place?) of adding a new bool paramet= er in struct rte_sched_port_params: clear_stats_on_reset? Both stats read function get the port handle (struct rte_sched_port *) as p= arameter, so there should be no ripple effect to propagate this flag. > = > > This e-mail and any attachments may contain confidential material for t= he > > sole use of the intended recipient(s). Any review or distribution by ot= hers > > is strictly prohibited. If you are not the intended recipient, please c= ontact > > the sender and delete all copies. > = > Please ask to your administrator to remove this disclaimer. I did earlier, this is still work in progress unfortunately. -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.