From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 50DD22E8A for ; Wed, 20 May 2015 00:49:13 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 19 May 2015 15:49:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,460,1427785200"; d="scan'208";a="573924333" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga003.jf.intel.com with ESMTP; 19 May 2015 15:49:06 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.59]) by IRSMSX109.ger.corp.intel.com ([169.254.13.51]) with mapi id 14.03.0224.002; Tue, 19 May 2015 23:49:05 +0100 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "Jastrzebski, MichalX K" , "Gajdzica, MaciejX T" Thread-Topic: [dpdk-dev] [PATCH v2 1/3] port: added WRITER_APPROACH == 1 implementation to ring port Thread-Index: AQHQkOrnks+OPzNBZU6TatDng/QCsJ2D6OTQ Date: Tue, 19 May 2015 22:49:05 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263236A14B@IRSMSX108.ger.corp.intel.com> References: <1430395084-6172-1-git-send-email-michalx.k.jastrzebski@intel.com> <1430395084-6172-2-git-send-email-michalx.k.jastrzebski@intel.com> <22373976.yBms5me9Vj@xps13> In-Reply-To: <22373976.yBms5me9Vj@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/3] port: added WRITER_APPROACH == 1 implementation to ring port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2015 22:49:13 -0000 HI Thomas and David, We can remove one of the code branches if you guys feel strongly about it. The reason we recommended to keep both is because both of them are working,= and we wanted to keep both of them for a while to get some feedback from o= ther people about which one they prefer. It might be that some apps would p= refer one over the other for performance reasons. But again, we can resend = this patch with only one code path present. Regards, Cristian > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Sunday, May 17, 2015 10:45 PM > To: Jastrzebski, MichalX K; Gajdzica, MaciejX T > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/3] port: added WRITER_APPROACH =3D=3D= 1 > implementation to ring port >=20 > 2015-04-30 13:58, Michal Jastrzebski: > > From: Maciej Gajdzica > > > > Added better optimized implementation of tx_bulk for ring writer port > > based on > > similar solution in ethdev_writer port. New implementation sends burst > > without > > copying data to internal buffer if it is possible. > > > > Signed-off-by: Maciej Gajdzica > [...] > > +#if RTE_PORT_RING_WRITER_APPROACH =3D=3D 0 >=20 > Nack > Maybe you missed the previous comment: > http://dpdk.org/ml/archives/dev/2015-March/015999.html