From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cristian.dumitrescu@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 11F929A9E
 for <dev@dpdk.org>; Tue, 26 May 2015 23:40:45 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga103.jf.intel.com with ESMTP; 26 May 2015 14:40:45 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,501,1427785200"; d="scan'208";a="732075742"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by fmsmga002.fm.intel.com with ESMTP; 26 May 2015 14:40:45 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.59]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.215]) with mapi id 14.03.0224.002;
 Tue, 26 May 2015 22:40:43 +0100
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, "Gajdzica, MaciejX T"
 <maciejx.t.gajdzica@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v3 01/10] table: added structure for storing
 table stats
Thread-Index: AQHQl8RlHS0FfsWld0ytGI8GA0FskZ2OyGsQ
Date: Tue, 26 May 2015 21:40:42 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263236CA8C@IRSMSX108.ger.corp.intel.com>
References: <1432643987-8916-1-git-send-email-maciejx.t.gajdzica@intel.com>
 <1432643987-8916-2-git-send-email-maciejx.t.gajdzica@intel.com>
 <20150526075754.791473f6@urahara>
In-Reply-To: <20150526075754.791473f6@urahara>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 01/10] table: added structure for storing
 table stats
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2015 21:40:46 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Tuesday, May 26, 2015 3:58 PM
> To: Gajdzica, MaciejX T
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 01/10] table: added structure for stori=
ng
> table stats
>=20
> On Tue, 26 May 2015 14:39:38 +0200
> Maciej Gajdzica <maciejx.t.gajdzica@intel.com> wrote:
>=20
> > +
> >  /** Lookup table interface defining the lookup table operation */
> >  struct rte_table_ops {
> >  	rte_table_op_create f_create;       /**< Create */
> > @@ -194,6 +218,7 @@ struct rte_table_ops {
> >  	rte_table_op_entry_add f_add;       /**< Entry add */
> >  	rte_table_op_entry_delete f_delete; /**< Entry delete */
> >  	rte_table_op_lookup f_lookup;       /**< Lookup */
> > +	rte_table_op_stats_read f_stats;	/**< Stats */
> >  };
>=20
> Another good idea, which is an ABI change.

This is simply adding a new API function, this is not changing any function=
 prototype. There is no change required in the map file of this library. Is=
 there anything we should have done and we did not do?