From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 7FEB5C386 for ; Thu, 28 May 2015 21:32:35 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 28 May 2015 12:32:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,513,1427785200"; d="scan'208";a="736947297" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga002.jf.intel.com with ESMTP; 28 May 2015 12:32:33 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.59]) by IRSMSX151.ger.corp.intel.com ([169.254.4.102]) with mapi id 14.03.0224.002; Thu, 28 May 2015 20:32:33 +0100 From: "Dumitrescu, Cristian" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v3 01/10] table: added structure for storing table stats Thread-Index: AQHQl8RlHS0FfsWld0ytGI8GA0FskZ2OyGsQ///1NwCAAwuykA== Date: Thu, 28 May 2015 19:32:32 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891263236E6E6@IRSMSX108.ger.corp.intel.com> References: <1432643987-8916-1-git-send-email-maciejx.t.gajdzica@intel.com> <1432643987-8916-2-git-send-email-maciejx.t.gajdzica@intel.com> <20150526075754.791473f6@urahara> <3EB4FA525960D640B5BDFFD6A3D891263236CA8C@IRSMSX108.ger.corp.intel.com> <20150526145732.022b5a41@urahara> In-Reply-To: <20150526145732.022b5a41@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 01/10] table: added structure for storing table stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 19:32:35 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, May 26, 2015 10:58 PM > To: Dumitrescu, Cristian > Cc: Gajdzica, MaciejX T; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 01/10] table: added structure for stori= ng > table stats >=20 > On Tue, 26 May 2015 21:40:42 +0000 > "Dumitrescu, Cristian" wrote: >=20 > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen > > > Hemminger > > > Sent: Tuesday, May 26, 2015 3:58 PM > > > To: Gajdzica, MaciejX T > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v3 01/10] table: added structure for > storing > > > table stats > > > > > > On Tue, 26 May 2015 14:39:38 +0200 > > > Maciej Gajdzica wrote: > > > > > > > + > > > > /** Lookup table interface defining the lookup table operation */ > > > > struct rte_table_ops { > > > > rte_table_op_create f_create; /**< Create */ > > > > @@ -194,6 +218,7 @@ struct rte_table_ops { > > > > rte_table_op_entry_add f_add; /**< Entry add */ > > > > rte_table_op_entry_delete f_delete; /**< Entry delete */ > > > > rte_table_op_lookup f_lookup; /**< Lookup */ > > > > + rte_table_op_stats_read f_stats; /**< Stats */ > > > > }; > > > > > > Another good idea, which is an ABI change. > > > > This is simply adding a new API function, this is not changing any func= tion > prototype. There is no change required in the map file of this library. I= s there > anything we should have done and we did not do? > > >=20 > But if I built an external set of code which had rte_table_ops (don't wor= ry I > haven't) > and that binary ran with the new definition, the core code it table would > reference > outside the (old version) of rte_table_ops structure and find garbage. This is just adding a new field at the end of an API data structure. Based= on input from multiple people and after reviewing the rules listed on http= ://dpdk.org/doc/guides/rel_notes/abi.html , I think this is an acceptable c= hange. There are other patches in flight on this mailing list that are in t= he same situation. Any typical/well behaved application will not break due = to this change.