From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A1E88C45C for ; Mon, 29 Jun 2015 21:47:52 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 29 Jun 2015 12:47:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,372,1432623600"; d="scan'208";a="596935729" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga003.jf.intel.com with ESMTP; 29 Jun 2015 12:47:51 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.201]) by IRSMSX102.ger.corp.intel.com ([169.254.2.117]) with mapi id 14.03.0224.002; Mon, 29 Jun 2015 20:47:50 +0100 From: "Dumitrescu, Cristian" To: "Mrzyglod, DanielX T" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] cfgfile: fix unitialised buffer Thread-Index: AQHQsn2c0n2FW2DvCUKBEKuBoYnCM53D47rg Date: Mon, 29 Jun 2015 19:47:49 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912632393071@IRSMSX108.ger.corp.intel.com> References: <1435307833-7432-1-git-send-email-danielx.t.mrzyglod@intel.com> <1435590363-4656-1-git-send-email-danielx.t.mrzyglod@intel.com> In-Reply-To: <1435590363-4656-1-git-send-email-danielx.t.mrzyglod@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] cfgfile: fix unitialised buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2015 19:47:53 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod > Sent: Monday, June 29, 2015 4:06 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3] cfgfile: fix unitialised buffer >=20 > Nature of the problem was not initialised buffer[256], there were probabi= lity > that operation system will provide previously used memory and on special > condition > there were probability that string operations will work on random data th= at > could provide unexpected program behaviour. >=20 > Changes in v3: > -Simplify the initialization of buffer. > Changes in v2: > -Found the real nature of problem. Only buffer was not initilized. > Changes in v1: > -Add additional separate IO buffer and initialize both buffers. >=20 Acked-by: Cristian Dumitrescu