From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2F7BC8D35 for ; Wed, 9 Sep 2015 20:21:32 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 09 Sep 2015 11:21:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,498,1437462000"; d="scan'208";a="786031660" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 09 Sep 2015 11:21:30 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 9 Sep 2015 19:21:29 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.12]) by irsmsx111.ger.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0224.002; Wed, 9 Sep 2015 19:21:29 +0100 From: "Dumitrescu, Cristian" To: Stephen Hemminger Thread-Topic: [PATCH 1/5] examples_ip_pipeline: fix typo's Thread-Index: AQHQ5FnMQvjdlLxdLkCBB5lylxyIUp40jxuA Date: Wed, 9 Sep 2015 18:21:28 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126478B9513@IRSMSX108.ger.corp.intel.com> References: <1441072746-29174-1-git-send-email-stephen@networkplumber.org> <1441072746-29174-2-git-send-email-stephen@networkplumber.org> In-Reply-To: <1441072746-29174-2-git-send-email-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/5] examples_ip_pipeline: fix typo's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2015 18:21:32 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Tuesday, September 1, 2015 4:59 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [PATCH 1/5] examples_ip_pipeline: fix typo's >=20 > Coverity found these as dead-code and/or copy-paste bugs. >=20 > Signed-off-by: Stephen Hemminger > --- > examples/ip_pipeline/config_parse.c | 2 +- > examples/ip_pipeline/config_parse_tm.c | 2 +- > examples/ip_pipeline/pipeline/pipeline_flow_classification.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/examples/ip_pipeline/config_parse.c > b/examples/ip_pipeline/config_parse.c > index c9b78f9..6b651a8 100644 > --- a/examples/ip_pipeline/config_parse.c > +++ b/examples/ip_pipeline/config_parse.c > @@ -2238,7 +2238,7 @@ save_pipeline_params(struct app_params *app, > FILE *f) > } >=20 > /* msgq_out */ > - if (p->n_msgq_in) { > + if (p->n_msgq_out) { > uint32_t j; >=20 > fprintf(f, "msgq_out =3D"); > diff --git a/examples/ip_pipeline/config_parse_tm.c > b/examples/ip_pipeline/config_parse_tm.c > index cdebbdc..84702b0 100644 > --- a/examples/ip_pipeline/config_parse_tm.c > +++ b/examples/ip_pipeline/config_parse_tm.c > @@ -399,7 +399,7 @@ tm_cfgfile_load(struct app_pktq_tm_params *tm) >=20 > memset(tm->sched_subport_params, 0, sizeof(tm- > >sched_subport_params)); > memset(tm->sched_pipe_profiles, 0, sizeof(tm- > >sched_pipe_profiles)); > - memset(&tm->sched_port_params, 0, sizeof(tm- > >sched_pipe_profiles)); > + memset(&tm->sched_port_params, 0, sizeof(tm- > >sched_port_params)); > for (i =3D 0; i < APP_MAX_SCHED_SUBPORTS * > APP_MAX_SCHED_PIPES; i++) > tm->sched_pipe_to_profile[i] =3D -1; >=20 > diff --git a/examples/ip_pipeline/pipeline/pipeline_flow_classification.c > b/examples/ip_pipeline/pipeline/pipeline_flow_classification.c > index 4b82180..24cf7dc 100644 > --- a/examples/ip_pipeline/pipeline/pipeline_flow_classification.c > +++ b/examples/ip_pipeline/pipeline/pipeline_flow_classification.c > @@ -442,7 +442,7 @@ app_pipeline_fc_add_bulk(struct app_params *app, > flow_rsp =3D rte_malloc(NULL, > n_keys * sizeof(struct pipeline_fc_add_bulk_flow_rsp), > RTE_CACHE_LINE_SIZE); > - if (flow_req =3D=3D NULL) { > + if (flow_rsq =3D=3D NULL) { > rte_free(flow_req); > rte_free(new_flow); > rte_free(signature); > -- > 2.1.4 Acked-by: Cristian Dumitrescu