From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/5] examples_ip_pipeline: remove useless code
Date: Wed, 9 Sep 2015 18:31:12 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126478B9561@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1441072746-29174-5-git-send-email-stephen@networkplumber.org>
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, September 1, 2015 4:59 AM
> To: Dumitrescu, Cristian
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: [PATCH 4/5] examples_ip_pipeline: remove useless code
>
> Code here checks return from strdup() in only one place in this
> whole module, and then does nothing useful by setting one
> value that is then cleared. Just remove the check.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> examples/ip_pipeline/config_parse.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/examples/ip_pipeline/config_parse.c
> b/examples/ip_pipeline/config_parse.c
> index 6b651a8..81ec33b 100644
> --- a/examples/ip_pipeline/config_parse.c
> +++ b/examples/ip_pipeline/config_parse.c
> @@ -1483,9 +1483,6 @@ parse_tm(struct app_params *app,
> ret = -ESRCH;
> if (strcmp(ent->name, "cfg") == 0) {
> param->file_name = strdup(ent->value);
> - if (param->file_name == NULL)
> - ret = -EINVAL;
> -
> ret = 0;
The required implementation would actually be:
if (param->file_name == NULL)
ret = -EINVAL;
else
ret = 0;
The TM parameter file_name is used by function app_config_parse_tm() in file config_parse_tm.c.
Regarding the way the error management (including the error messages) is done in our parser (currently done by repeatedly setting the ret variable), I would like to improve (replace) when I get the time to take another look at this.
> } else if (strcmp(ent->name, "burst_read") == 0)
> ret = parser_read_uint32(¶m->burst_read,
> --
> 2.1.4
next prev parent reply other threads:[~2015-09-09 18:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 1:59 [dpdk-dev] [PATCH 0/5] fixup ip pipeline examples Stephen Hemminger
2015-09-01 1:59 ` [dpdk-dev] [PATCH 1/5] examples_ip_pipeline: fix typo's Stephen Hemminger
2015-09-09 18:21 ` Dumitrescu, Cristian
2015-09-01 1:59 ` [dpdk-dev] [PATCH 2/5] example_ip_pipeline: avoid strncpy issue Stephen Hemminger
2015-09-09 18:22 ` Dumitrescu, Cristian
2015-09-10 8:44 ` Bruce Richardson
2015-09-01 1:59 ` [dpdk-dev] [PATCH 3/5] example_ip_pipeline: fix sizeof() on memcpy Stephen Hemminger
2015-09-09 18:25 ` Dumitrescu, Cristian
2015-09-09 18:47 ` Stephen Hemminger
2015-09-01 1:59 ` [dpdk-dev] [PATCH 4/5] examples_ip_pipeline: remove useless code Stephen Hemminger
2015-09-09 18:31 ` Dumitrescu, Cristian [this message]
2015-09-01 1:59 ` [dpdk-dev] [PATCH 5/5] examples_ip_pipeline: fix possible string overrun Stephen Hemminger
2015-09-09 18:33 ` Dumitrescu, Cristian
2015-09-09 18:35 ` [dpdk-dev] [PATCH 0/5] fixup ip pipeline examples Dumitrescu, Cristian
2015-10-07 16:43 ` Thomas Monjalon
2015-10-12 14:51 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D89126478B9561@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).