From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cristian.dumitrescu@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id B8F6FCE7
 for <dev@dpdk.org>; Tue, 22 Sep 2015 13:37:02 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 22 Sep 2015 04:34:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,572,1437462000"; d="scan'208";a="566175859"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by FMSMGA003.fm.intel.com with ESMTP; 22 Sep 2015 04:34:14 -0700
Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by
 IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 22 Sep 2015 12:34:12 +0100
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.216]) by
 irsmsx111.ger.corp.intel.com ([169.254.2.89]) with mapi id 14.03.0248.002;
 Tue, 22 Sep 2015 12:34:12 +0100
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, "Azarewicz, PiotrX T"
 <piotrx.t.azarewicz@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v1 1/3] port: add mp/mc ring ports
Thread-Index: AQHQ9L3RcBRdJ8kTrEqxaT0KiM6tFZ5Ia07A
Date: Tue, 22 Sep 2015 11:34:11 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126478D65D5@IRSMSX108.ger.corp.intel.com>
References: <1442322395-23365-1-git-send-email-piotrx.t.azarewicz@intel.com>
 <1442322395-23365-2-git-send-email-piotrx.t.azarewicz@intel.com>
 <20150921153530.0b198652@urahara>
In-Reply-To: <20150921153530.0b198652@urahara>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 1/3] port: add mp/mc ring ports
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2015 11:37:03 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Tuesday, September 22, 2015 1:36 AM
> To: Azarewicz, PiotrX T
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 1/3] port: add mp/mc ring ports
>=20
> On Tue, 15 Sep 2015 15:06:33 +0200
> Piotr Azarewicz <piotrx.t.azarewicz@intel.com> wrote:
>=20
> > +static inline void
> > +send_burst_mp(struct rte_port_ring_writer *p)
> > +{
>=20
> compiler will inline static functions anyway. No need to add inline quali=
fier

Hi Stephen,

Using 'static inline' seems to be the standard practice in DPDK and a good =
practice as well.

DPDK> grep 'static inline' `find -name '*.[hc]'` | wc -l
1700

Regards,
Cristian