From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 91FCB2B9F for ; Wed, 30 Mar 2016 16:16:11 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 30 Mar 2016 07:16:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,416,1455004800"; d="scan'208";a="921835352" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 30 Mar 2016 07:15:59 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.13]) by IRSMSX104.ger.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0248.002; Wed, 30 Mar 2016 15:15:01 +0100 From: "Dumitrescu, Cristian" To: Thomas Monjalon CC: "dev@dpdk.org" , "Singh, Jasvinder" , "Zhang, Roy Fan" , "Hunt, David" Thread-Topic: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2 Thread-Index: AQHRio3Lx9xDFds9ZkuMJAm2mU6gSp9yB86w Date: Wed, 30 Mar 2016 14:15:01 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126479745AA@IRSMSX108.ger.corp.intel.com> References: <1455605170-16137-1-git-send-email-thomas.monjalon@6wind.com> <1455605170-16137-3-git-send-email-thomas.monjalon@6wind.com> <3EB4FA525960D640B5BDFFD6A3D891264797454E@IRSMSX108.ger.corp.intel.com> <1519299.Ljb19TASP1@xps13> In-Reply-To: <1519299.Ljb19TASP1@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDhiNWVhMDQtNjRjNC00YzhlLTliMDUtNzE2ZGMzYmEyYmU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikx4Y1BoaDFrZ3ZDRjN2Y2FKazJoZlBEVDVBTXplcFwvOE45U3VqaWZQcGprPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 14:16:12 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, March 30, 2016 3:07 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Singh, Jasvinder ; Zhang, > Roy Fan ; Hunt, David > Subject: Re: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build fo= r > x86_64 without SSE4.2 >=20 > 2016-03-30 13:57, Dumitrescu, Cristian: > > I think the correct fix is: > > #if defined(__x86_64__) && (defined(RTE_MACHINE_CPUFLAG_SSE4_2) > || defined(RTE_MACHINE_CPUFLAG_CRC32)) > > > > We'll test it and send a patch asap. >=20 > I had prepared this patch. Please be inspired: >=20 > examples/ip_pipeline: fix SSE4.2 optimization branch >=20 > The branch was disabled because of a typo in the SSE4.2 flag. > Change also the x86_64 flag to use a DPDK one. >=20 > Fixes: 28377375c6c0 ("examples/ip_pipeline: fix build for x86_64 with= out > SSE4.2") >=20 > -#if defined(__x86_64__) && defined(RTE_CPUFLAG_SSE4_2) > +#if defined(RTE_ARCH_X86_64) && > defined(RTE_MACHINE_CPUFLAG_SSE4_2) Acked-by: Cristian Dumitrescu