From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 7B15E47D1 for ; Thu, 28 Apr 2016 12:58:58 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 28 Apr 2016 03:58:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,546,1455004800"; d="scan'208";a="954700248" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga001.fm.intel.com with ESMTP; 28 Apr 2016 03:58:57 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.238]) by IRSMSX107.ger.corp.intel.com ([169.254.10.228]) with mapi id 14.03.0248.002; Thu, 28 Apr 2016 11:58:55 +0100 From: "Dumitrescu, Cristian" To: "Jastrzebski, MichalX K" , "Zhang, Roy Fan" , "Singh, Jasvinder" CC: "dev@dpdk.org" , "Mrozowicz, SlawomirX" Thread-Topic: [PATCH v2] examples/qos_sched: fix negative loop bound Thread-Index: AQHRm8O1NuH9EWVAk0GMVfmiDMtLA5+fQlAA Date: Thu, 28 Apr 2016 10:58:54 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126479A6E9C@IRSMSX108.ger.corp.intel.com> References: <1461239256-8104-1-git-send-email-michalx.k.jastrzebski@intel.com> <1461239256-8104-4-git-send-email-michalx.k.jastrzebski@intel.com> In-Reply-To: <1461239256-8104-4-git-send-email-michalx.k.jastrzebski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2JkNDlkYWUtNmU3Zi00OTljLTllOGItMDcxYjk5NWJkOGFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjYrRnFWb2lmdjY0U3BPbERjQVZGK3NpMnFCU1Vla1VFSThaUmJVUjRMdUE9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/qos_sched: fix negative loop bound X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2016 10:58:58 -0000 > -----Original Message----- > From: Jastrzebski, MichalX K > Sent: Thursday, April 21, 2016 12:48 PM > To: Dumitrescu, Cristian ; Zhang, Roy Fan > ; Singh, Jasvinder > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > > Subject: [PATCH v2] examples/qos_sched: fix negative loop bound >=20 > From: Slawomir Mrozowicz >=20 > Coverity ID 30704: Negative loop bound > negative_returns: Using unsigned variable n_tokens in a loop exit conditi= on. >=20 > Fixes: de3cfa2c9823 ("sched: initial import") >=20 > Signed-off-by: Slawomir Mrozowicz > --- > examples/qos_sched/args.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c > index 3e7fd08..7a98e5c 100644 > --- a/examples/qos_sched/args.c > +++ b/examples/qos_sched/args.c > @@ -162,7 +162,7 @@ static int > app_parse_opt_vals(const char *conf_str, char separator, uint32_t n_vals= , > uint32_t *opt_vals) > { > char *string; > - uint32_t i, n_tokens; > + int i, n_tokens; > char *tokens[MAX_OPT_VALUES]; >=20 > if (conf_str =3D=3D NULL || opt_vals =3D=3D NULL || n_vals =3D=3D 0 || = n_vals > > MAX_OPT_VALUES) > -- > 1.9.1 Acked-by: Cristian Dumitrescu