From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 19FADA254 for ; Tue, 21 Jun 2016 11:03:19 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 21 Jun 2016 02:03:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,503,1459839600"; d="scan'208";a="832298545" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 21 Jun 2016 02:03:18 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.183]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002; Tue, 21 Jun 2016 10:03:16 +0100 From: "Dumitrescu, Cristian" To: =?iso-8859-1?Q?Simon_K=E5gstr=F6m?= , "stephen@networkplumber.org" , "dev@dpdk.org" , "thomas.monjalon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH / RFC] sched: Correct subport calcuation Thread-Index: AQHRwuF4U+gnjDuHuUqGWV+Hi48N7J/zeTYAgAA4USA= Date: Tue, 21 Jun 2016 09:03:15 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D8912647A0A57B@IRSMSX108.ger.corp.intel.com> References: <20160610082913.4878ab77@miho> <5768E17A.4060404@netinsight.net> In-Reply-To: <5768E17A.4060404@netinsight.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTYyOTkxOWUtMDdkYy00MTk3LWIxZTUtMjljMzg4ZDdlN2MyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjkxRkllUVwvNVM4T1RBYmFUczErdWVxXC9XTFNab1cyeWRvSElEdlI3XC9JXC84PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH / RFC] sched: Correct subport calcuation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 09:03:20 -0000 Hi Simon, I am going to take a look at it this week and come back to you. Thanks, Cristian > -----Original Message----- > From: Simon K=E5gstr=F6m [mailto:simon.kagstrom@netinsight.net] > Sent: Tuesday, June 21, 2016 7:41 AM > To: Dumitrescu, Cristian ; > stephen@networkplumber.org; dev@dpdk.org; > thomas.monjalon@6wind.com > Subject: Re: [dpdk-dev] [PATCH / RFC] sched: Correct subport calcuation >=20 > Hi again! >=20 > Any news about this patch? I'm off for parental leave starting next week > (until january), so any comments (or simply dropping it!) would be good > to have before that :-) >=20 > // Simon >=20 > On 2016-06-10 08:29, Simon Kagstrom wrote: > > Signed-off-by: Simon Kagstrom > > --- > > I'm a total newbie to the rte_sched design and implementation, so I've > > added the RFC. > > > > We get crashes (at other places in the scheduler) without this code. > > > > lib/librte_sched/rte_sched.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.= c > > index 1609ea8..b46ecfb 100644 > > --- a/lib/librte_sched/rte_sched.c > > +++ b/lib/librte_sched/rte_sched.c > > @@ -1869,7 +1869,7 @@ grinder_next_pipe(struct rte_sched_port *port, > uint32_t pos) > > > > /* Install new pipe in the grinder */ > > grinder->pindex =3D pipe_qindex >> 4; > > - grinder->subport =3D port->subport + (grinder->pindex / port- > >n_pipes_per_subport); > > + grinder->subport =3D port->subport + (grinder->pindex / port- > >n_subports_per_port); > > grinder->pipe =3D port->pipe + grinder->pindex; > > grinder->pipe_params =3D NULL; /* to be set after the pipe structure = is > prefetched */ > > grinder->productive =3D 0; > >